defichain-wallet icon indicating copy to clipboard operation
defichain-wallet copied to clipboard

Remove screen name translations in navigators

Open mbochmann opened this issue 3 years ago • 1 comments

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

Names of Screens in Navigators should not be translated because they will be used as keys for deep linking.

Which issue(s) does this PR fixes?:

Fixes #3383

Additional comments?:

Developer Checklist:

  • [x] Read your code changes at least once
  • [x] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • [x] No console errors on web
  • [x] Tested on Light mode and Dark mode*
  • [x] Your UI implementation visually matched the rendered design*

mbochmann avatar Aug 31 '22 05:08 mbochmann

Code Climate has analyzed commit 12e8cd3b and detected 0 issues on this pull request.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Aug 31 '22 05:08 qlty-cloud-legacy[bot]

Thanks for creating this PR, we have implemented the same changes in another PR #3691, which we are also resetting the navigation stack after language switch.

kyleleow avatar Oct 25 '22 08:10 kyleleow