defichain-wallet icon indicating copy to clipboard operation
defichain-wallet copied to clipboard

feature(core): composite(instant/future) swap v2 update

Open G9000 opened this issue 1 year ago â€ĸ 6 comments

What kind of PR is this?:

/kind

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • [ ] Read your code changes at least once
  • [ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • [ ] No console errors on web
  • [ ] Tested on Light mode and Dark mode*
  • [ ] Your UI implementation visually matched the rendered design*
  • [ ] Unit tests*
  • [ ] Added e2e tests*
  • [ ] Added translations*

G9000 avatar Aug 30 '22 06:08 G9000

@G9000: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind fix
  • /kind chore
  • /kind docs
  • /kind refactor
  • /kind dependencies
Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Aug 30 '22 06:08 github-actions[bot]

Code Climate has analyzed commit 60bed3ba and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 10

View more on Code Climate.

codeclimate[bot] avatar Aug 30 '22 06:08 codeclimate[bot]

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1565,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1565,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1565,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1565,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1565,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

defichain-bot avatar Aug 30 '22 06:08 defichain-bot

Deploy Preview for mobile-wallet-preview ready!

Name Link
Latest commit 60bed3bae8cdfaae2b39cf0f65e2f3b9ed0bd45f
Latest deploy log https://app.netlify.com/sites/mobile-wallet-preview/deploys/6310f578cfccbb000af3ebcd
Deploy Preview https://deploy-preview-3381--mobile-wallet-preview.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 30 '22 06:08 netlify[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (pierregee/swap-v2@c94c484). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 60bed3b differs from pull request most recent head 69ef1d4. Consider uploading reports for the commit 69ef1d4 to get more accurate results

@@                 Coverage Diff                  @@
##             pierregee/swap-v2    #3381   +/-   ##
====================================================
  Coverage                     ?   65.29%           
====================================================
  Files                        ?      458           
  Lines                        ?    11910           
  Branches                     ?     3757           
====================================================
  Hits                         ?     7777           
  Misses                       ?     4067           
  Partials                     ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 30 '22 06:08 codecov[bot]

Build preview for DeFiChain Wallet is ready!

Built with commit b2e3d6f16cb2642d97a7b6eef52ee195868b3f70

https://expo.io/@defichain/wallet?release-channel=pr-preview-3381

defichain-bot avatar Aug 30 '22 06:08 defichain-bot

Deploy Preview for wallet-defichain ready!

Name Link
Latest commit 60bed3bae8cdfaae2b39cf0f65e2f3b9ed0bd45f
Latest deploy log https://app.netlify.com/sites/wallet-defichain/deploys/6310f57829b1580007f9cb47
Deploy Preview https://deploy-preview-3381--wallet-defichain.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 01 '22 08:09 netlify[bot]



Test summary

489 â€ĸ 28 â€ĸ 1 â€ĸ 21


Run details

Project wallet
Status Failed
Commit e308e0fa81 ℹī¸
Started Sep 1, 2022 6:13 PM
Ended Sep 1, 2022 6:42 PM
Duration 28:53 💡
OS Linux Ubuntu - 20.04
Browser Chrome 105

View run in Cypress Dashboard ➡ī¸


Failures

futureswap.spec.ts 7 Failed
1 Wallet - DEX - Future Swap > should have no swap option on crypto -> loan combination
2 Wallet - DEX - Future Swap > should have no swap option on crypto -> crpyto combination
3 Wallet - DEX - Future Swap > should have no swap option on loan -> loan combination
4 Wallet - DEX - Future Swap > should have no swap option on loan -> crypto combination
5 Wallet - DEX - Future Swap > should have no swap option on dfi -> crypto combination
6 Wallet - DEX - Future Swap > should display future swap option if Loan token -> DUSD selected
7 Wallet - DEX - Future Swap > should display oracle price -5% if Loan token -> DUSD selected
compositeswap.spec.ts 3 Failed
1 Wallet - DEX - Swap without balance > should disable token selection on pool pair w/o balance
2 Wallet - DEX - Composite Swap with disabled pool pairs > should disable pool swap button if pair is disabled on API
3 Wallet - DEX - Composite Swap without balance > should disable token selection on pool pair w/o balance
This comment includes only the first 10 test failures. See all 28 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 01 '22 09:09 cypress[bot]