defichain-wallet icon indicating copy to clipboard operation
defichain-wallet copied to clipboard

fix(ui-ux): add cancel prompt function on all transaction

Open G9000 opened this issue 3 years ago • 8 comments

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Adding cancel prompt functionality on the following transaction screen:

  • Send
  • Convert
  • Add Liquidity
  • Remove Liquidity
  • Dex composite swap

Update the following affected e2e but does not fix the whole e2e as its kinda huge. Might want to fix on separate PR:

  • Convert spec
  • Remove liquidity spec
  • Send spec
  • Address spec

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • [x] Read your code changes at least once
  • [x] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • [x] No console errors on web
  • [x] Tested on Light mode and Dark mode*
  • [x] Your UI implementation visually matched the rendered design*
  • [x] Unit tests*
  • [x] Added e2e tests*
  • [x] Added translations*

G9000 avatar Aug 25 '22 04:08 G9000

Code Climate has analyzed commit d5650c85 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Aug 25 '22 04:08 qlty-cloud-legacy[bot]

Deploy Preview for mobile-wallet-preview ready!

Name Link
Latest commit d23c1846fb020a2e3befa0bf8fa0a5d8370a635b
Latest deploy log https://app.netlify.com/sites/mobile-wallet-preview/deploys/630723ca81db6b00088d8a68
Deploy Preview https://deploy-preview-3362--mobile-wallet-preview.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 25 '22 04:08 netlify[bot]

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1897,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1897,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1897,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1897,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1897,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

defichain-bot avatar Aug 25 '22 04:08 defichain-bot

Codecov Report

Base: 20.22% // Head: 43.09% // Increases project coverage by +22.86% :tada:

Coverage data is based on head (d5650c8) compared to base (4344077). Patch coverage: 9.09% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3362       +/-   ##
===========================================
+ Coverage   20.22%   43.09%   +22.86%     
===========================================
  Files         482      493       +11     
  Lines       12769    12969      +200     
  Branches     4159     4196       +37     
===========================================
+ Hits         2583     5589     +3006     
+ Misses      10142     7314     -2828     
- Partials       44       66       +22     
Impacted Files Coverage Δ
.../screens/Dex/CompositeSwap/CompositeSwapScreen.tsx 71.98% <ø> (+71.98%) :arrow_up:
...s/Dex/CompositeSwap/ConfirmCompositeSwapScreen.tsx 0.00% <0.00%> (ø)
...ppNavigator/screens/Dex/DexConfirmAddLiquidity.tsx 37.28% <0.00%> (+37.28%) :arrow_up:
.../screens/AppNavigator/screens/Dex/DexNavigator.tsx 56.25% <ø> (+50.00%) :arrow_up:
...app/screens/AppNavigator/screens/Dex/DexScreen.tsx 76.81% <ø> (+76.08%) :arrow_up:
...AppNavigator/screens/Dex/PoolPairDetailsScreen.tsx 0.00% <ø> (ø)
...AppNavigator/screens/Dex/components/SwapButton.tsx 100.00% <ø> (+25.00%) :arrow_up:
...Navigator/screens/Portfolio/PortfolioNavigator.tsx 50.00% <ø> (+47.50%) :arrow_up:
...ns/Portfolio/screens/ConvertConfirmationScreen.tsx 0.00% <0.00%> (ø)
...reens/Portfolio/screens/SendConfirmationScreen.tsx 0.00% <0.00%> (ø)
... and 165 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 25 '22 04:08 codecov[bot]

Build preview for DeFiChain Wallet is ready!

Built with commit 938d0b234ac1c606b9a9639897fbb48cf1ee6884

https://expo.io/@defichain/wallet?release-channel=pr-preview-3362

defichain-bot avatar Aug 25 '22 04:08 defichain-bot



Test summary

426 78 1 57


Run details

Project wallet
Status Failed
Commit 938d0b234a ℹ️
Started Oct 25, 2022 2:11 AM
Ended Oct 25, 2022 2:43 AM
Duration 32:37 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡️


Failures

dex/swap/swap_future_withdraw.spec.ts Failed
1 Wallet - Future Swap -> Display -> Withdraw flow > should future swap DUSD -> dTU10
portfolio/send.spec.ts Failed
1 Wallet - Send - Address book > should be able to add new address
2 Wallet - Send - Address book > should not have favourite button in Your addresses tab
3 Wallet - Send - Address book > should be able to select address from address book and display in address input
4 Wallet - Send - Address book > should be able to select wallet address and display default label in address input
5 Wallet - Send - Address book > should be able to block duplicate address
6 Wallet - Send - Address book > should be able to block wallet address
7 Wallet - Send - Address book > should disable add new, edit and favourite button has has refresh button in Your address tab
8 Wallet - Send - Address book > should remove address book from storage after exiting wallet through setting
9 Wallet - Send - Address book > should remove address book from storage after forced exit from invalid passcode
This comment includes only the first 10 test failures. See all 78 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 19 '22 04:09 cypress[bot]

@G9000 I will move this to next release

thedoublejay avatar Sep 29 '22 05:09 thedoublejay

Bug:

  1. Top up DUSD and DFI
  2. Go to DEX screen, press top liquidity DUSD-DFI pool see screenshot
  3. Add liquidity + continue and press cancel
  4. Issue: Redirected back to Portfolio page image

pierregee avatar Oct 12 '22 06:10 pierregee

  1. add_liquidity.spec seems to be failing consistently after the cancel prompt image can just fix in another PR

pierregee avatar Oct 25 '22 05:10 pierregee