`loan` - update max loan amount can be borrowed and condition to borrow loan

[kyleleow]

What happened:

• In borrow loan page, currently max loan amount can be borrowed is calculated based on total collateral value and min col ratio
• In borrow loan page, if total DFI in collateral is less than 50%, user is not able to proceed to borrow loan
• In edit collateral page of a vault that has active loans, reducing the collateral of DFI/DUSD to below 50% is blocked by UI

What you expected to happen:

• Update calculation: Max loan amount = 2 * (DFI and DUSD in collateral) / min col ratio
• Update blocking condition to take loan
• Update condition to change collateral amount

How to reproduce it (as minimally and precisely as possible):

• Create new vault > add 1 DFI and 1 DUSD as collateral > add 10 BTC as collateral > borrow DUSD loan token, noticed the max loan amount is incorrect, and UI is blocking user from proceeding

Anything else we need to know?:

related: #2564

[github-actions[bot]]

@kyleleow: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

[github-actions[bot]]

@kyleleow: Thanks for opening an issue, an appropriate priority will be added soon.

The priority labels can be added by foundation members by writing /priority [type] in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

[thedoublejay]

Linked https://github.com/DeFiCh/wallet/issues/2616