janeway icon indicating copy to clipboard operation
janeway copied to clipboard

Not all journals have a default_cover_image

Open joemull opened this issue 1 year ago • 3 comments

Adding a new journal without a default cover image breaks the press journals list

joemull avatar Feb 15 '24 13:02 joemull

@joemull this issue should be over on Hourglass, the core themes all check for default cover image.

ajrbyers avatar Feb 15 '24 13:02 ajrbyers

Sorry, should have spelled this out a bit more but was in a rush. I do think there should be a press-level setting in Janeway so that new journal setups don't have to fill this one in urgently.

I'll also fix the Hourglass templates.

joemull avatar Feb 15 '24 16:02 joemull

While we're at it, would be great to add a model property that keeps us from having to do this logic in templates.

joemull avatar Feb 15 '24 16:02 joemull