janeway
janeway copied to clipboard
BirkbeckCTP
3857 breadcrumb remove currentpage href
I have worked through the known areas of this issue one directory at a time, and each has its own commit on this branch. Then there will be a final commit coming which tidies up any typos and trailing tags that were missed.
The breadcrumbs have been implemented in three different ways -
- some were fully within the template itself,
- some used an include to a breadcrumb template within elements/breadcrumbs,
- and some used the include while listing the current page after it within the main template.
This fix was about making sure that final item in the list was not a link.
For 1. there was a simple fix of removing the <a> tags from the final item.
For 2 and 3, Where an include was used, it needed to work for templates that only used the include, and those which had a final line in the template - i.e. sometimes return a list of links, and sometimes a list where the last item was not a link. some of the time the problem was within the include, and then within the same section there might be some templates which used the include and then listed the current page with or without tags in the main template. Fixing this across each section required the some includes to be updated and some of the main templates, and some templates then worked without modification due to the updated includes. Where there was a subpage listed within the main template, I have updated the includes with the suffix with subpage="Yes"so that the include can then display all items as links.
This is mostly done, but given how many changes were made, I will now review the changes on github so that I can check for any typos or trailing </a> that have not been caught already.
One other thing I forgot to mention: because we use the typesetting plugin as a normal part of the standard workflow (and are planning to integrate it) we should at some point soon make the same changes there so that the workflow is consistent.
