janeway icon indicating copy to clipboard operation
janeway copied to clipboard

Isolate code that loads hooks.

Open gamboz opened this issue 2 years ago • 3 comments

So that django apps (i.e. not Janway plugins) can register their own hooks.

This is the same as PR #2941 (unfortunately I wasn't able to just re-open the old one).

gamboz avatar Sep 21 '22 12:09 gamboz

Sorry, I see that I have some failing checks. I've set the PR as draft, I'll fix them and be back :(

gamboz avatar Sep 22 '22 06:09 gamboz

Can't replicate the errors locally. I think the PR is ok :)

gamboz avatar Sep 28 '22 12:09 gamboz

I think they are both fixed in master so should be fine.

ajrbyers avatar Sep 28 '22 12:09 ajrbyers

Test this please

ajrbyers avatar Nov 04 '22 10:11 ajrbyers

@ajrbyers I think this needs to be rebased if we want the test to pass. Shall I rebase it?

joemull avatar Nov 04 '22 11:11 joemull

@ajrbyers I think this needs to be rebased if we want the test to pass. Shall I rebase it?

Yeah go ahead, I don't think Mr Jenkins is listening to me so maybe the rebase process will push the test.

ajrbyers avatar Nov 04 '22 11:11 ajrbyers