janeway icon indicating copy to clipboard operation
janeway copied to clipboard

links in <comment> text in <ref> being displayed out-of-order

Open pgoussy opened this issue 1 year ago • 0 comments

Describe the bug If a URL is contained within <comment> tags in a bibliographic <ref>, that URL will be pulled out and displayed after the closing </comment>, rather than appearing where it was tagged in the flow of text.

Janeway version 1.4.1

To Reproduce Steps to reproduce the behavior:

  1. Go to https://journals.publishing.umich.edu/ergo/plugins/typesetting/preview_galley/article/1133/galley/432/#heading10
  2. Scroll down to "Suikkanen, Jussi" (near the end of the References section)
  3. Note that the access URL is displaying at the end of the reference (between the access date and the closing period) rather than where it was tagged originally (immediately after "Available online at").

Expected behavior In order to maintain fidelity to the original article, any URL should appear in the flow of text where it has been tagged, regardless of whatever tags that text might be wrapped in (like <comment>)

Screenshots 2022-08-12_14-51-50

Reference is displaying like so: Suikkanen Jussi (2009). Metaethics, Semantics, and Metasemantics. Available online at . Accessed in April 2020https://peasoup.princeton.edu/2009/07/metaethics-semantics-and-metasemantics.

When, instead, it should be displaying like so: Suikkanen Jussi (2009). Metaethics, Semantics, and Metasemantics. Available online at https://peasoup.princeton.edu/2009/07/metaethics-semantics-and-metasemantics. Accessed in April 2020.

Here is the JATS tagging for this reference:

<ref id="R50">
<mixed-citation publication-type="web">
<person-group person-group-type="author"><string-name><surname>Suikkanen</surname> <given-names>Jussi</given-names></string-name></person-group> (<year>2009</year>). 
<source>Metaethics, Semantics, and Metasemantics.</source> 
<comment>Available online at <ext-link xmlns:xlink="http://www.w3.org/1999/xlink" ext-link-type="uri" xlink:href="https://peasoup.princeton.edu/2009/07/metaethics-semantics-and-metasemantics" xlink:type="simple">https://peasoup.princeton.edu/2009/07/metaethics-semantics-and-metasemantics</ext-link>. Accessed in April 2020</comment>.
</mixed-citation>
</ref>

pgoussy avatar Aug 12 '22 18:08 pgoussy