janeway icon indicating copy to clipboard operation
janeway copied to clipboard

Published 20 hours ago • verified publisher icon BirkbeckCTP

Email Subjects on Template

Open ajrbyers opened this issue 1 year ago • 2 comments

Describe the bug Currently the email subject value displayed is hard coded on the template.

Janeway version 1.4.1

Expected behavior The email subject for the template being sent should be displayed.

Additional We should check that all email subjects conform to the pattern: subject_name_of_related_template this can be achieved by a test and will also identify any that do not conform.

ajrbyers avatar Jul 27 '22 16:07 ajrbyers

  • [x] In typesetting some emails (emails.py) do not pull a setting from the database.
  • [x] The APC plugin has no email subjects

ajrbyers avatar Aug 01 '22 16:08 ajrbyers

See PRs on Typesetting and APC:

  • https://github.com/BirkbeckCTP/apc/pull/22
  • https://github.com/BirkbeckCTP/typesetting/pull/167

ajrbyers avatar Aug 02 '22 09:08 ajrbyers

@ajrbyers In addition to the PRs on apc and typesetting, does the fix for this involve https://github.com/BirkbeckCTP/janeway/compare/3043-email_subjects ? Ready for a PR?

joemull avatar Sep 08 '22 13:09 joemull

Mmm we agreed this wouldn’t go forward as @mauromsl was making changes to these templates.

ajrbyers avatar Sep 08 '22 13:09 ajrbyers

Mmm we agreed this wouldn’t go forward as @mauromsl was making changes to these templates.

OK, then is there anything that I can do on this issue @ajrbyers @mauromsl ? I set the status to in progress.

joemull avatar Sep 13 '22 15:09 joemull

See this PR: https://github.com/BirkbeckCTP/janeway/pull/3121

ajrbyers avatar Sep 13 '22 15:09 ajrbyers