Section editors cannot access some submissions they get notifications for

[joemull]

Problem

When a new submission comes in, Janeway notifies relevant parties by email, including section editors affiliated with the section to which an article is submitted:

https://github.com/BirkbeckCTP/janeway/blob/5511797544a27e30751b156474b08da42f401fb6/src/utils/transactional_emails.py#L392-L395

However, to actually see an article, a section editor has to be assigned to the article, not just to the containing section:

https://github.com/BirkbeckCTP/janeway/blob/5511797544a27e30751b156474b08da42f401fb6/src/security/decorators.py#L190-L193

https://github.com/BirkbeckCTP/janeway/blob/a9cf805db1e095421ed5c3d524ef097fdd690e24/src/submission/models.py#L1152-L1153

There is a setting that if turned on will auto-assign articles submitted to a section to that section's editors, but we can't depend on it being switched on 100% of the time.

As a result, some guest editors or section editors will get links in their inbox that won't work, causing frustration and confusion.

Suggested

Change the article method section_editors quoted above to check not whether the editor is assigned to the article but to the relevant section, as the name of the function suggests.

[ajrbyers]

Change the article method section_editors quoted above to check not whether the editor is assigned to the article but to the relevant section, as the name of the function suggests.

I think we will need to canvass opinion on this as its a large change to how we expect SE's to work at the moment. Its currently a feature that SE's do not have unfettered access to all articles in their section and is also the reason the auto-assign feature exists.

We could instead only notify SEs of the new submission if the setting is enabled.

[joemull]

OK, I'll collect some perspectives from editors who work with section editors.