janeway
janeway copied to clipboard
2936 ported popup email logic and form to core and added view to repositories so managers can email preprint owners from inside Janeway.
Closes #2936
Local testing worked fine, and I've confirmed that this passes tests (after rebasing this branch on master, which has a fix for a failing test on MySQL). We're running more tests on our dev instance, to give it a fair shake, but signs are looking good.
Testing now. Just to double confirm: should we expect to see record of attachments or CCed addresses in the message log? (I'm not seeing them.)
On Mon, 18 Jul 2022, 15:23 Hardy Pottinger, @.***> wrote:
Local testing worked fine, and I've confirmed that this passes tests (after rebasing this branch on master, which has a fix for a failing test on MySQL). We're running more tests on our dev instance, to give it a fair shake, but signs are looking good.
— Reply to this email directly, view it on GitHub https://github.com/BirkbeckCTP/janeway/pull/2953#issuecomment-1188173253, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXIQB2W6NBM4DWLYQLQ6VLVUWVK7ANCNFSM5ZQCAFQQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
This looks approved, I'd feel better if it were merged :-) hint hint