Birgit Bader

Results 19 comments of Birgit Bader

Can you take a look at this PR, @thomasklinger1234 @jensfischer1515, thx :)

Can you take a look at this PR, @thomasklinger1234 @jensfischer1515, thx :)

Relates to https://github.com/otto-ec/ottoapi_portal/issues/1950

## Comment history Feb 22, 2023 by @cfranzen > Why not stick to the ISO standard for formatting currencies? (https://de.wikipedia.org/wiki/ISO_4217) Can we rely on euros as currency? I think Otto...

Feb 23, 2023 by @thake I've compiled an overview of some possible formats and their pro's and con's: ![image](https://user-images.githubusercontent.com/12547985/220875769-90b1478a-fdd4-46d3-ba34-b8115c731e31.png)

Feb 23, 2023 by @jensfischer1515 Historical background after some software archaeological research: * Checkout API price modelling was copied from legacy Order API (REST for ordering OTTO products only) in...

Feb 28, 2023 by @thake OrderEvent of kraken uses: ```json { "price": {"amount": 10.34, "currency": "EUR"} }

Feb 28, 2023 by @thake ## Proposal My proposed format after a discussion with @jensfischer1515, @JanKlasser3000, @BastianSperrhacke-Otto, and @sergey-kolodiev ### Example ```json { "price": {"amount": "1.45", "currency": "EUR" /* optional,...

Mar 2, 2023 by @cfranzen > I think that is a good proposal, although I dislike the type of amount being string. Most languages / frameworks would handle type "number"...

Mar 2, 2023 by @thake > Regarding the type of `amount`: @JanKlasser3000 did some research and found that other APIs on the market also use string (e.g., Paypal and Amazon)....