cordless icon indicating copy to clipboard operation
cordless copied to clipboard

Texteditor heighcalculation incorrect

Open Bios-Marcel opened this issue 6 years ago • 3 comments

Is your source up to date

  • [x] Yes
  • [ ] No

What happened

The texteditor often unnecessarily requests more height.

What did you expect to happen

That more height is only requested if the user actually filled the current line or manually inserts a linebreak.

How do you reproduce this bug

Just type a lot.

How to fix

Correct the line count calculation. This probably needs to be a feature of Bios-Marcel/tview, because that is the only place knowing about the line wrapping.

System information

Key Value
OS Ubuntu-18.10
Architechture x64

Bios-Marcel avatar Feb 10 '19 01:02 Bios-Marcel

I haven't been able to replicate this issue - is it still happening for you? If so, what terminal are you using?

avahe-kellenberger avatar Jul 12 '19 13:07 avahe-kellenberger

Yeah, I can still replicate this, type something like this:

wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww wwwwwwwwwwwwwwwwwwwwwwww

at some point it won't have enough height.

I am using termite (vte based).

Bios-Marcel avatar Jul 12 '19 13:07 Bios-Marcel

I see, just happened in mine - the very top line gets cut off. Will look into this soon (probably this evening)

avahe-kellenberger avatar Jul 12 '19 13:07 avahe-kellenberger