cordless icon indicating copy to clipboard operation
cordless copied to clipboard

Online users aren't displayed correctly

Open Bios-Marcel opened this issue 6 years ago • 4 comments

Is your source up to date

  • [x] Yes
  • [ ] No

What happened

The list of online users on the right side is totally incorrect.

What did you expect to happen

A correct listing with the correct role weights.

How do you reproduce this bug

Open cordless and chose a server.

Error output

None

System information

Key Value
OS Ubuntu 18.04
Architechture x64

Bios-Marcel avatar Jan 20 '19 13:01 Bios-Marcel

Have you decided on a layout for the user tree panel?

If not, I suppose we could use a specific term color for all offline users. I'm looking through the code to get familiar, let me know your thoughts.

avahe-kellenberger avatar Jul 10 '19 14:07 avahe-kellenberger

The thing should work as follows:

  • Displays all users of a group / guild
  • Offline users all have a constant color (gray or so)
  • Role colors should be ignored, as we are on a terminal and we don't have proper color support on every terminal
  • Offline users should not be shown by default and can be toggled via some command
  • The layout can stay as it is

EDIT I am open to suggestions

Bios-Marcel avatar Jul 10 '19 14:07 Bios-Marcel

I like all of that, but would argue that offline users should be shown by default since it's the default functionality of the official client - just have them sorted into an "offline" node, or sorted to the bottom?

avahe-kellenberger avatar Jul 11 '19 18:07 avahe-kellenberger

Oh right yeah, I didn't think of that. Sure, that is probably better.

Bios-Marcel avatar Jul 11 '19 18:07 Bios-Marcel