imgbrd-grabber icon indicating copy to clipboard operation
imgbrd-grabber copied to clipboard

Published 20 hours ago • verified publisher icon Bionus

Adding new Favorites to large Favorites list hangs the Grabber process temporarily

Open VeggieJay opened this issue 1 year ago • 2 comments

Bug description

With a large favorites list ~4000 entries, adding additional favorites hangs the process temporarily for 6-7 seconds. If the Favorites sidebar is open (View->Favorites) then this extends to 10-15 seconds.

Steps to reproduce

  1. View->Favorites to bring up sidebar
  2. Go to Search, add any tag when you have a long Favorites list
  3. (Not Responding)

Expected behavior

Being able to add/remove favorites without any delays

Context

My current favorites.json is about 520kb and 3900 entries Sorry can't provide it out of shame

Screenshots

Grabber Not Responding Sidebar example

System information

  • OS: Windows 10
  • Grabber version: Nightly b2452be3
  • Running from an SSD

VeggieJay avatar May 24 '23 05:05 VeggieJay

Could be fixed by using proper model/views for favorites in the UI as it seems most of the time spent is done by Qt rendering new widgets created when refreshing the favorites lists.

Bionus avatar May 30 '23 19:05 Bionus

Opening any favorite page causes hanging(Not Responding) and eventually crashing. Even tried this after removing some favorites.

Any other workarounds?

GregRGM avatar Sep 03 '23 23:09 GregRGM