imgbrd-grabber Missing Qt5PrintSupport.dll in the latest nightly

Missing Qt5PrintSupport.dll in the latest nightly

Open adem4ik opened this issue 1 year ago • 9 comments

Bug description

Latest nightly doesn't start after fresh install. Windows reports that Qt5PrintSupport.dll is missing.

Steps to reproduce

Delete installed Grabber (at least the files from its installation folder)
Install latest Grabber_nightly_x64.exe from https://github.com/Bionus/imgbrd-grabber/releases/nightly
Run Grabber

Expected behavior

Normal Grabber start.

Context

N/A

Screenshots

System information

OS: Windows 10
Grabber version: nightly https://github.com/Bionus/imgbrd-grabber/commit/98c5b37b48d0eb0524db28cd0019d94c4d6a8326

Additional context

Can't be reproduced in the stable 7.9.1.

Jul 24 '22 10:07 adem4ik

Strange, I removed it recently because it should not have been necessary. windeployqt deems it unnecessary (hence its non-presence in ZIP releases), and nowhere in Grabber are there any printing being done.

I guess I'll add it back although it's very confusing.

Jul 24 '22 23:07 Bionus

@Bionus I'm not that experienced enough. But 7.9.1 version doesn't have Qt5PrintSupport.dll inside its installation folder after fresh install and it runs fine. While latest nightly https://github.com/Bionus/imgbrd-grabber/commit/98c5b37b48d0eb0524db28cd0019d94c4d6a8326 runs only with Qt5PrintSupport.dll (which I got from some older version). Mb nightly build just needs some requirements changes? 7.9.1:

Jul 25 '22 13:07 adem4ik

Even stranger then, but great info 🕵️‍♂️

Because the build process is pretty much identical between both, differences are truly minor. I guess I'll have to investigate to see which of those minor changes could add a dependency on printing.

Jul 25 '22 21:07 Bionus

That file is missing from the latest portable release (7.11.0_x64)