imgbrd-grabber icon indicating copy to clipboard operation
imgbrd-grabber copied to clipboard

Confirmation on closing window doesn't work if only 1 tab is open

Open adem4ik opened this issue 1 year ago • 1 comments

Bug description

Ask for confirmation before closing the window option doesn't work.

Steps to reproduce

  1. Run Grabber
  2. Enable Ask for confirmation before closing the window option (default)
  3. Close Grabber window

Expected behavior

Confirmation is shown.

Context

Screenshots

image

System information

  • OS: Windows 10
  • Grabber version: latest nightly https://github.com/Bionus/imgbrd-grabber/commit/98c5b37b48d0eb0524db28cd0019d94c4d6a8326

Additional context

Afaik it worked some time ago, but this issue is reproducible at least since 7.7.1.

adem4ik avatar Jul 24 '22 09:07 adem4ik

The wording is confusing, but this only applies when there is more than one tab open, or when a batch download is in progress. I just tested it out and it was working. I guess it could be changed, I don't remember the rationale for this logic.

Bionus avatar Jul 24 '22 23:07 Bionus