IRanges icon indicating copy to clipboard operation
IRanges copied to clipboard
verified publisher icon Bioconductor

ALTREP patch

Open Jiefei-Wang opened this issue 6 years ago • 0 comments

Hi Herve,

Here is the pull request for fixing ALTREP problem in IRange constructor. The main changes are:

  1. Use GET/SET function to access data from a vector
  2. Remove C level type check and length check, since they are done at the R level.

The patch only affects the constructor function. I see there is an iranges_holder structure at C level that is also related to IRange object, but the change of it will affect many functions, so I did not touch it and would also like to ask if it is OK to work on it.

Best, Jiefei

Jiefei-Wang avatar Sep 06 '19 17:09 Jiefei-Wang