Contributions icon indicating copy to clipboard operation
Contributions copied to clipboard

doubletrouble

Open almeidasilvaf opened this issue 2 years ago • 7 comments

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

  • Repository: https://github.com/almeidasilvaf/doubletrouble

Confirm the following by editing each check box to '[x]'

  • [x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.

  • [x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.

  • [x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.

  • [x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.

  • [x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.

  • [x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.

  • [x] I am familiar with the Bioconductor code of conduct and agree to abide by it.

I am familiar with the essential aspects of Bioconductor software management, including:

  • [x] The 'devel' branch for new packages and features.
  • [x] The stable 'release' branch, made available every six months, for bug fixes.
  • [x] Bioconductor version control using Git (optionally via GitHub).

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

almeidasilvaf avatar Oct 06 '22 12:10 almeidasilvaf

Hi @almeidasilvaf

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: doubletrouble
Title: Identification and classification of duplicated genes
Version: 0.99.0
Date: 2022-05-29
Authors@R: 
    c(
    person(given = "Fabrício",
 family = "Almeida-Silva",
 role = c("aut", "cre"),
 email = "[email protected]",
 comment = c(ORCID = "0000-0002-5314-2964")),
    person(given = "Yves",
 family = "Van de Peer",
 role = "aut",
 email = "[email protected]",
 comment = c(ORCID = "0000-0003-4327-3730"))
    )
Description: doubletrouble aims to identify duplicated genes from
    whole-genome protein sequences and classify them based on their modes
    of duplication. The duplication modes are: 
    i. whole-genome duplication (WGD);
    ii. tandem duplication (TD);
    iii. proximal duplication (PD);
    iv. transposed duplication (TRD) and;
    v. dispersed duplication (DD).
    If users want a simpler classification scheme, duplicates can also be
    classified into WGD- and SSD-derived (small-scale duplication) gene pairs.
    Besides classifying gene pairs, users can also classify genes, so that
    each gene is assigned a unique mode of duplication. 
    Users can also calculate substitution rates per substitution site (i.e., Ka
    and Ks) from duplicate pairs, find peaks in Ks distributions with Gaussian
    Mixture Models (GMMs), and classify gene pairs into age groups based on Ks
    peaks.
License: GPL-3
URL: https://github.com/almeidasilvaf/doubletrouble
BugReports: https://support.bioconductor.org/t/doubletrouble
biocViews: 
    Software,
    WholeGenome,
    ComparativeGenomics,
    FunctionalGenomics,
    Phylogenetics,
    Network
Encoding: UTF-8
LazyData: false
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.0
Imports:
    syntenet,
    GenomicRanges,
    Biostrings,
    mclust,
    MSA2dist (>= 1.1.5),
    ggplot2,
    stats,
    utils
Depends: 
    R (>= 4.2.0)
Suggests: 
    testthat (>= 3.0.0),
    knitr,
    feature,
    BiocStyle,
    rmarkdown,
    covr,
    sessioninfo
Config/testthat/edition: 3
VignetteBuilder: knitr

bioc-issue-bot avatar Oct 06 '22 12:10 bioc-issue-bot

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot avatar Oct 11 '22 17:10 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/doubletrouble to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Oct 11 '22 17:10 bioc-issue-bot

Thanks @almeidasilvaf, this was extremely pleasurable to review. The code was nicely written and the vignette was clear. There are plenty of tests and examples.

  • [ ] The only thing I think worth changing is when you use the colon operator 1:2, can easily be replaced by c(1, 2) and is much easier to read. For longer regular sequances is safer to use the appropriate seq.

ococrook avatar Oct 26 '22 14:10 ococrook

Received a valid push on git.bioconductor.org; starting a build for commit id: ce28f43ed9e5f4accf90a10751dc54d2777235dc

bioc-issue-bot avatar Oct 27 '22 07:10 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/doubletrouble to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Oct 27 '22 07:10 bioc-issue-bot

Hi, @ococrook

Thank you very much for your feedback!

  • [x] The only thing I think worth changing is when you use the colon operator 1:2, can easily be replaced by c(1, 2) and is much easier to read. For longer regular sequances is safer to use the appropriate seq.

Agreed. I replaced m:n with c(m, n) or seq(m, n, by = 1) throughout.

Best, Fabricio

almeidasilvaf avatar Oct 27 '22 07:10 almeidasilvaf

Thanks Fabricio, I'm happy to accept the package after a tiny fix. Could you update the NEWS.md file so it matches the Desciption file?

ococrook avatar Nov 04 '22 14:11 ococrook

Received a valid push on git.bioconductor.org; starting a build for commit id: 0d8851d97675e5d7c12c7b52144e58af9c5d5b1b

bioc-issue-bot avatar Nov 05 '22 11:11 bioc-issue-bot

Hi, @ococrook

Done.

almeidasilvaf avatar Nov 05 '22 11:11 almeidasilvaf

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/doubletrouble to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Nov 05 '22 11:11 bioc-issue-bot

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

bioc-issue-bot avatar Nov 07 '22 11:11 bioc-issue-bot

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/almeidasilvaf.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("doubletrouble"). The package 'landing page' will be created at

https://bioconductor.org/packages/doubletrouble

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.

lshep avatar Nov 09 '22 14:11 lshep