Contributions icon indicating copy to clipboard operation
Contributions copied to clipboard

BioMartGOGeneSets

Open jokergoo opened this issue 1 year ago • 12 comments

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

  • Repository: https://github.com/jokergoo/BioMartGOGeneSets

Confirm the following by editing each check box to '[x]'

  • [x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.

  • [x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.

  • [x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.

  • [x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.

  • [x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.

  • [x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.

  • [x] I am familiar with the Bioconductor code of conduct and agree to abide by it.

I am familiar with the essential aspects of Bioconductor software management, including:

  • [x] The 'devel' branch for new packages and features.
  • [x] The stable 'release' branch, made available every six months, for bug fixes.
  • [x] Bioconductor version control using Git (optionally via GitHub).

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

jokergoo avatar Sep 20 '22 12:09 jokergoo

Hi @jokergoo

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: BioMartGOGeneSets
Type: Package
Title: Gene Ontology Gene Sets from BioMart
Version: 0.99.0
Date: 2022-09-20
Authors@R: person("Zuguang", "Gu", email = "[email protected]", role = c("aut", "cre"),
        comment = c('ORCID'="0000-0002-7395-8709"))
Depends: R (>= 4.2.0)
Imports: utils, S4Vectors
Suggests: biomaRt, GO.db, GenomicRanges, knitr, testthat
biocViews: AnnotationData, Organism
Description: It contains pre-compiled Gene Ontology gene sets for all organisms
    available on the Ensembl database. It also includes GO gene sets for organisms 
    on Ensembl Plants, Ensembl Metazoa, Ensembl Fungi and Ensembl Protists. 
    The data was collected with the biomaRt package.
VignetteBuilder: knitr
URL: https://github.com/jokergoo/BioMartGOGeneSets
License: MIT + file LICENSE
NeedsCompilation: no

bioc-issue-bot avatar Sep 20 '22 12:09 bioc-issue-bot

This package provides pre-compiled GO gene sets for more than 600 organisms from BioMart. Manually creating such gene sets is not difficult (as we have demonstrated in https://jokergoo.github.io/BioMartGOGeneSets/articles/biomart.html), but it would still be nice if the gene sets are already compiled and especially good for the users who are not experienced with Bioconductor or studying non-model organisms.

The script for generating the gene sets is also included in the package (https://github.com/jokergoo/BioMartGOGeneSets/blob/master/inst/scripts/biomart_genesets.R). Currently all the gene set data are stored on github.io (https://github.com/jokergoo/BioMartGOGeneSets_data). We will update the data regularly.

jokergoo avatar Sep 20 '22 12:09 jokergoo

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot avatar Sep 26 '22 14:09 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/BioMartGOGeneSets to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Sep 26 '22 14:09 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: 49e01e9fd22f5d82a8acabcfb98032f9d74eb21e

bioc-issue-bot avatar Sep 26 '22 15:09 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/BioMartGOGeneSets to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Sep 26 '22 15:09 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: 03e002eee362c1f487994ac5ae38d2bd581cdc3d

bioc-issue-bot avatar Sep 27 '22 08:09 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/BioMartGOGeneSets to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Sep 27 '22 08:09 bioc-issue-bot

Trying to review, hitting

--- re-building ‘biomart.Rmd’ using rmarkdown
Ensembl site unresponsive, trying uswest mirror
Ensembl site unresponsive, trying asia mirror
Quitting from lines 83-86 (biomart.Rmd) 
Error: processing vignette 'biomart.Rmd' failed with diagnostics:

vjcitn avatar Oct 06 '22 19:10 vjcitn

I think this should be an internet issue when connecting to the BioMart web service (using biomaRt package). There might be one of the following two reasons:

  1. Currently you cannot connect to Ensembl BioMart service? Maybe you can try it later.
  2. These lines retrieve GO-gene relations for all GO terms. The data is relatively huge. The downloading might be interrupted? (This is unlikely because I guess if so it will give a different error message)

Now I save the intermediate results (GO-gene relations in lines 83-86) to an object, and these lines are not executed in the vignette while I directly read the cached object. Hope this problem will be solved.

jokergoo avatar Oct 06 '22 19:10 jokergoo

Received a valid push on git.bioconductor.org; starting a build for commit id: 140a24be82a3a031405d5759ba7cb087b1c04a73

bioc-issue-bot avatar Oct 06 '22 19:10 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/BioMartGOGeneSets to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Oct 06 '22 19:10 bioc-issue-bot

Every time I try to review, it fails. Can you introduce some fault tolerance so that the value of the package is illustrated even if the networking fails? Messages to the user about what happens in the ideal case?

--- re-building ‘biomart.Rmd’ using rmarkdown
Quitting from lines 63-65 (biomart.Rmd) 
Error: processing vignette 'biomart.Rmd' failed with diagnostics:
Timeout was reached: [www.ensembl.org:443] Operation timed out after 10000 milliseconds with 294464 bytes received
--- failed re-building ‘biomart.Rmd’

vjcitn avatar Oct 28 '22 14:10 vjcitn

Received a valid push on git.bioconductor.org; starting a build for commit id: 366cafe8220f370e7d9bf907db6715dac6ed9029

bioc-issue-bot avatar Nov 03 '22 12:11 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/BioMartGOGeneSets to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Nov 03 '22 12:11 bioc-issue-bot

--- re-building ‘biomart.Rmd’ using rmarkdown
Quitting from lines 63-65 (biomart.Rmd) 
Error: processing vignette 'biomart.Rmd' failed with diagnostics:
Timeout was reached: [www.ensembl.org:443] Operation timed out after 10000 milliseconds with 294464 bytes received
--- failed re-building ‘biomart.Rmd’                                 ~~~~~~~~~~~~~~~~~~

I can see the timeout limit on your machine is only 10 seconds. I guess it relates to which biomart mirror to use. As far as I have checked, the useast mirror has a timeout limit of 10 seconds and uswest mirror has a timeout limit of 5min.

The vignette "biomart.Rmd" has nothing related to the functionalities of the BioMartGOGeneSets package. It is just a demonstration of how the data is gathered. Now in the new version, I directly generated the corresponding .md file for this vignette.

Also in the vignette, I additionally inform users to change the biomart mirrors when they see the "timeout" error.

jokergoo avatar Nov 03 '22 12:11 jokergoo

Received a valid push on git.bioconductor.org; starting a build for commit id: 714bf41ca60637d489362122930c784664daad9b

bioc-issue-bot avatar Nov 03 '22 12:11 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/BioMartGOGeneSets to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Nov 03 '22 12:11 bioc-issue-bot

The error was a false positive:

    * ERROR: Maintainer must subscribe to the bioc-devel mailing list.

I've already subscribed the bioc-devel mailing list.

jokergoo avatar Nov 03 '22 12:11 jokergoo

I can confirm user is subscribed to mailing list.

lshep avatar Nov 03 '22 12:11 lshep

Received a valid push on git.bioconductor.org; starting a build for commit id: 666f772b3b8905f667d55593e1e3504c26e3ef40

bioc-issue-bot avatar Nov 03 '22 14:11 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/BioMartGOGeneSets to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Nov 03 '22 14:11 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: 26fc2dc0d279b30d9b958e907f96236c5620d9b9

bioc-issue-bot avatar Nov 03 '22 14:11 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/BioMartGOGeneSets to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Nov 03 '22 14:11 bioc-issue-bot