Contributions icon indicating copy to clipboard operation
Contributions copied to clipboard

SFEData, SpatialFeatureExperiment, and Voyager

Open lambdamoses opened this issue 3 years ago • 35 comments
trafficstars

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

  • Repository: https://github.com/pachterlab/SFEData

Confirm the following by editing each check box to '[x]'

  • [x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.

  • [x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.

  • [x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.

  • [x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.

  • [x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.

  • [x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.

  • [x] I am familiar with the Bioconductor code of conduct and agree to abide by it.

I am familiar with the essential aspects of Bioconductor software management, including:

  • [x] The 'devel' branch for new packages and features.
  • [x] The stable 'release' branch, made available every six months, for bug fixes.
  • [x] Bioconductor version control using Git (optionally via GitHub).

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

lambdamoses avatar Jul 15 '22 17:07 lambdamoses

Hi @lambdamoses

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: SFEData
Title: Example SpatialFeatureExperiment datasets
Version: 0.99.0
Authors@R: 
    c(person("Lambda", "Moses", email = "[email protected]", 
    role = c("aut", "cre"),
    comment = c(ORCID = "0000-0002-7092-9427")),
    person("Lior", "Pachter", email = "[email protected]",
    role = c("aut", "ths"),
    comment = c(ORCID = "0000-0002-9164-6231")))
Description: 
    Example spatial transcriptomics datasets with Simple Feature annotations
    as SpatialFeatureExperiment objects. In the first version, the only full
    dataset is a mouse skeletal muscle Visium dataset 2 days after notexin
    injury from 'Large-scale integration of single-cell transcriptomic data 
    captures transitional progenitor states in mouse skeletal muscle 
    regeneration'. More datasets will be added in later versions.
Imports:
    AnnotationHub,
    ExperimentHub
Suggests: 
    knitr,
    rmarkdown,
    SpatialFeatureExperiment,
    testthat (>= 3.0.0)
License: GPL-3
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.0
biocViews: 
    ExperimentHub,
    ExpressionData,
    Mus_musculus_Data,
    SpatialData,
    Tissue,
    SingleCellData
VignetteBuilder: knitr
Config/testthat/edition: 3

bioc-issue-bot avatar Jul 15 '22 17:07 bioc-issue-bot

Will you be following the https://github.com/Bioconductor/Contributions#submitting-related-packages so that SpatialFeatureExperiment is in place for checking SFEData?

vjcitn avatar Jul 22 '22 13:07 vjcitn

I installed SpatialFeatureExperiment from pachterlab repo to check this package and it seemed fine. You will need to submit SpatialFeatureExperiment too, as a related package.

vjcitn avatar Jul 22 '22 14:07 vjcitn

@vjcitn to have the interface for submitting related packages work correctly they can't submit it until the data package is already in review with a 'review in progress' tag (and therefore already initialized in the review process). If it is good please proceed with the 'pre-check passed'

lshep avatar Jul 22 '22 14:07 lshep

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot avatar Jul 22 '22 18:07 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/SFEData to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Jul 22 '22 18:07 bioc-issue-bot

AdditionalPackage: https://github.com/pachterlab/SpatialFeatureExperiment

lambdamoses avatar Jul 23 '22 02:07 lambdamoses

Hi @lambdamoses, Thanks for submitting your additional package: https://github.com/pachterlab/SpatialFeatureExperiment. We are taking a quick look at it and you will hear back from us soon.

bioc-issue-bot avatar Jul 23 '22 02:07 bioc-issue-bot

AdditionalPackage: https://github.com/pachterlab/Voyager

lambdamoses avatar Jul 23 '22 02:07 lambdamoses

Hi @lambdamoses, Thanks for submitting your additional package: https://github.com/pachterlab/Voyager. We are taking a quick look at it and you will hear back from us soon.

bioc-issue-bot avatar Jul 23 '22 02:07 bioc-issue-bot

Hi, bump your version numbers/commit/push to get a new build.

vjcitn avatar Aug 04 '22 17:08 vjcitn

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot avatar Aug 08 '22 14:08 bioc-issue-bot

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot avatar Aug 08 '22 14:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/SpatialFeatureExperiment to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 08 '22 14:08 bioc-issue-bot

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot avatar Aug 08 '22 14:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/SpatialFeatureExperiment to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 08 '22 15:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/Voyager to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 08 '22 15:08 bioc-issue-bot

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot avatar Aug 08 '22 16:08 bioc-issue-bot

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot avatar Aug 08 '22 16:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/SpatialFeatureExperiment to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 08 '22 16:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/SpatialFeatureExperiment to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 08 '22 16:08 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: 11579860423af00cea4cf7f2f36a5298c659b02d

bioc-issue-bot avatar Aug 15 '22 19:08 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: 624514c3976d27cf38c903dd2410d2bbae47f9a3

bioc-issue-bot avatar Aug 15 '22 19:08 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: d13cd4cf79d885c6304769e0fd66ae9e55367b00

bioc-issue-bot avatar Aug 15 '22 19:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/SpatialFeatureExperiment to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 15 '22 19:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/SFEData to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 15 '22 20:08 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: e05e870d05ceeebf15498c0c27cad69a31419a09

bioc-issue-bot avatar Aug 15 '22 20:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/Voyager to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 15 '22 20:08 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/SFEData to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Aug 15 '22 20:08 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: d219d04006c84d50843413acdc5f2e4e0bcab5f6

bioc-issue-bot avatar Aug 15 '22 20:08 bioc-issue-bot