Contributions icon indicating copy to clipboard operation
Contributions copied to clipboard

UniProtKeywords

Open jokergoo opened this issue 2 years ago • 5 comments

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

  • Repository: https://github.com/jokergoo/UniProtKeywords

Confirm the following by editing each check box to '[x]'

  • [x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.

  • [x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.

  • [x] I understand Bioconductor Package Naming Policy and acknowledge Bioconductor may retain use of package name.

  • [x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.

  • [x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.

  • [x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.

  • [x] I am familiar with the Bioconductor code of conduct and agree to abide by it.

I am familiar with the essential aspects of Bioconductor software management, including:

  • [x] The 'devel' branch for new packages and features.
  • [x] The stable 'release' branch, made available every six months, for bug fixes.
  • [x] Bioconductor version control using Git (optionally via GitHub).

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

jokergoo avatar Jun 27 '22 20:06 jokergoo

Hi @jokergoo

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: UniProtKeywords
Type: Package
Title: Keywords from the UniProt database
Version: 0.99.0
Date: 2022-06-27
Authors@R: person("Zuguang", "Gu", email = "[email protected]", role = c("aut", "cre"),
        comment = c('ORCID'="0000-0002-7395-8709"))
Depends: R (>= 4.2)
Imports: utils
Suggests: knitr, rmarkdown, markdown, testthat
biocViews: AnnotationData, Organism, Homo_sapiens
Description: UniProt database provides a list of controlled vocabulary represented as keywords
   for genes or proteins. This is useful for summarizing gene functions in a compact way. This package
   provides data of keywords hierarchy and gene-keywords relations.
VignetteBuilder: knitr
URL: https://github.com/jokergoo/UniProtKeywords, https://www.uniprot.org/keywords/
BugReports: https://github.com/jokergoo/UniProtKeywords/issues
License: MIT + file LICENSE
NeedsCompilation: no

bioc-issue-bot avatar Jun 27 '22 20:06 bioc-issue-bot

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot avatar Jul 13 '22 14:07 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/UniProtKeywords to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Jul 13 '22 14:07 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: 2665150c27acc50915cab60559e4d427360400d6

bioc-issue-bot avatar Jul 14 '22 11:07 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/UniProtKeywords to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Jul 14 '22 11:07 bioc-issue-bot

Received a valid push on git.bioconductor.org; starting a build for commit id: 277e9c2cc5e5f8b332165d37f05d41c2ebf38961

bioc-issue-bot avatar Sep 06 '22 15:09 bioc-issue-bot

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to [email protected]:packages/UniProtKeywords to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot avatar Sep 06 '22 15:09 bioc-issue-bot

It's a nice package but I am somewhat concerned about the arbitrary nature of the resource that it is built on. "Keywords", not an ontology, not clear what kind of versioning is done, and so forth. It works, if you can add some details on provenance and updating policy that will be great.

vjcitn avatar Sep 17 '22 21:09 vjcitn

Your package has been accepted. It will be added to the Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor community. If you are interested in becoming a Bioconductor package reviewer, please see Reviewers Expectations.

bioc-issue-bot avatar Sep 17 '22 21:09 bioc-issue-bot

Thanks! Sure I will add more information of the version of the data and other related things.

jokergoo avatar Sep 18 '22 10:09 jokergoo

Dear @jokergoo ,

We have reopened the issue to continue the review process. Please remember to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot avatar Sep 26 '22 11:09 bioc-issue-bot

do not close the issue -- we will process it and add it to the daily builder but it must remain open until then. I was away on holiday last week; I will process the issues in the next day or two.

lshep avatar Sep 26 '22 11:09 lshep

The master branch of your GitHub repository has been added to Bioconductor's git repository.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/jokergoo.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/ https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("UniProtKeywords"). The package 'landing page' will be created at

https://bioconductor.org/packages/UniProtKeywords

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.

lshep avatar Sep 26 '22 13:09 lshep

Hi @jokergoo Shouldn't this use the UniProt API rather than a static file in the package? Best, Marcel

LiNk-NY avatar Nov 02 '22 15:11 LiNk-NY

Hi Marcel, I think the API is only convenient for getting record for e.g. single protein/gene?

jokergoo avatar Nov 03 '22 11:11 jokergoo

You can get the table with the URL that they provide on the website: E.g., (with pagination)

https://rest.uniprot.org/keywords/search?compressed=true&fields=id%2Cname%2Ccategory%2Cgene_ontologies&format=tsv&query=%28%2A%29&size=500

LiNk-NY avatar Nov 03 '22 18:11 LiNk-NY