Biostrings icon indicating copy to clipboard operation
Biostrings copied to clipboard

Published 20 hours ago • verified publisher icon Bioconductor

Convert Biostrings2classes.Rnw to .Rmd

Open villafup opened this issue 2 years ago • 6 comments

@Bioconductor/sweave2rmd for review

villafup avatar Sep 21 '22 14:09 villafup

@villafup Please remove .Rnw file. I don't think you need to modify the DESCRIPTION because there are other PRs that add BiocStyle

jwokaty avatar Feb 17 '23 22:02 jwokaty

@villafup @jwokaty Where are we standing with this PR?

hpages avatar Jun 27 '23 18:06 hpages

We are waiting on some changes from @villafup. I'll slack him :)

jwokaty avatar Jun 27 '23 18:06 jwokaty

@hpages @jwokaty what is the status of this and #90 ? Are these still being worked on, and if not, can we merge/close them?

ahl27 avatar Jun 06 '24 19:06 ahl27

I'm surprised this vignette made it to the sweave2rmd list. It's very old and outdated and doesn't have much value anymore. It was written to document the classes that I introduced when I took over the package and transitioned it from Biostrings 1 to Biostrings 2 about 18 years ago! The only reason it's still around is that Biostrings doesn't have a good general vignette, so I guess having the "Biostrings 2 classes" vignette was better than nothing. However we should start thinking about addressing that @ahl27. In the mean time I think it's ok to close this unless @jwokaty or @villafup oppose. Thanks!

hpages avatar Jun 06 '24 22:06 hpages

Sounds good, I'll wait for either of them to chime in to confirm and then we can consider closing it.

Is the other PR still something we need to merge? I can ping you on that PR so the conversation stays localized to the PR

ahl27 avatar Jun 07 '24 00:06 ahl27