BiocParallel icon indicating copy to clipboard operation
BiocParallel copied to clipboard

BiocParallel:::.batchtoolsClusterAvailable() mistakes Torque for SGE

Open HenrikBengtsson opened this issue 5 years ago • 0 comments

Not sure whether or not false positives are expected or not, but on a Torque/PBS cluster, BiocParallel:::.batchtoolsClusterAvailable("sge") returns TRUE (with BiocParallel 1.25.1):

> sapply(c("sge", "slurm", "lsf", "openlava", "torque"), BiocParallel:::.batchtoolsClusterAvailable)
     sge    slurm      lsf openlava   torque 
    TRUE    FALSE    FALSE    FALSE     TRUE 

Vice versa, on an SGE cluster, BiocParallel:::.batchtoolsClusterAvailable("torque") returns TRUE:

> sapply(c("sge", "slurm", "lsf", "openlava", "torque"), BiocParallel:::.batchtoolsClusterAvailable)
     sge    slurm      lsf openlava   torque 
    TRUE    FALSE    FALSE    FALSE     TRUE 

The problem seems to be that both SGE and Torque got qstat and qselect commands;

https://github.com/Bioconductor/BiocParallel/blob/d762d9ee5238ccd1026fd9158f87d799453c9eb2/R/BatchtoolsParam-class.R#L41-L60

HenrikBengtsson avatar Nov 25 '20 19:11 HenrikBengtsson