containers icon indicating copy to clipboard operation
containers copied to clipboard

Add Dockerfile for TCRdock v1.0.0

Open eliasball opened this issue 1 year ago • 9 comments

Submitting a Container

Checklist

  1. Misc
  • [x] My tool doesn't exist in BioConda
  • [x] The image can be built
  • To build the image, --ulimit nofile=262144:262144 needs to provided to docker build. How should this be done in Biocontainers?
  1. Metadata
  • [x] LABEL base_image
  • [x] LABEL version
  • [x] LABEL software.version
  • [x] LABEL about.summary
  • [x] LABEL about.home
  • [x] LABEL about.license
  • [x] MAINTAINER
  1. Extra (optionals)
  • [ ] I have written tests in test-cmds.txt
  • [ ] LABEL extra.identifier
  • [x] LABEL about.documentation
  • [x] LABEL about.license_file
  • [x] LABEL about.tags

eliasball avatar Jan 11 '24 10:01 eliasball

Hey! One more thing before the PR could potentially be accepted: As mentioned above, to build the image, --ulimit nofile=262144:262144 needs to provided to docker build. How should this be done in Biocontainers?

eliasball avatar Jan 11 '24 10:01 eliasball

Also, the software provided is not my software, but I forked the repo and added some important files to make the docker container build. Is it alright to provide only the links to my fork in the LABELS?

eliasball avatar Jan 11 '24 10:01 eliasball

about.license field is not in spdx list: https://spdx.org/licenses/, if it is a typo error, please fix it. If this is not a standard license, please specify Custom License and use about.license_file label to specify license location (in container or url).

biocontainers-bot avatar Jan 15 '24 08:01 biocontainers-bot

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

biocontainers-bot avatar Jan 15 '24 08:01 biocontainers-bot

No test-cmds.txt (test file) present, skipping tests

biocontainers-bot avatar Jan 15 '24 08:01 biocontainers-bot

Hmm, it seems to build fine on our end without the --ulimit. (Which is great, because there are not easy way to include those in the build process).

Not sure regarding the fork. Is the maintainer not interested in merging your modifications in the main repo?

mboudet avatar Jan 15 '24 09:01 mboudet

I see, this is good news! The --ulimit was related to a bug when installing cudatoolkit (https://github.com/mamba-org/mamba/issues/2501#issuecomment-1582182711) and the fix simply requires it to be not set too high. Great that it works without on our build system!

Regarding the fork: I haven't contacted the maintainer about this topic, as it was simpler to just devise the necessary env.yml file myself and have control over release versioning. If this is wished for I could do this however.

eliasball avatar Jan 15 '24 10:01 eliasball

Well, I feel like it would be cleaner to link to the main repo. If the maintainer does not wish to incorporate the modifications, we can proceed as it is.

mboudet avatar Jan 15 '24 10:01 mboudet

Alright, I will open a PR for the main repo and contact the maintainer, I will reach out once everything works, thanks a lot! :)

eliasball avatar Jan 15 '24 10:01 eliasball