bindsnet icon indicating copy to clipboard operation
bindsnet copied to clipboard

bug in examples/breakout

Open ioneliabuzatu opened this issue 10 months ago • 2 comments

bug in https://github.com/BindsNET/bindsnet/blob/master/bindsnet/environment/environment.py#L92.

gym.make("env_name") instaed of gym.make(env_id="env_name"). at some point they changed the arg "env_id" to just "id"

original error when running random_baseline.py:

TypeError: make() missing 1 required positional argument: 'id'

ioneliabuzatu avatar Mar 26 '24 11:03 ioneliabuzatu

another bug when running random_network_baseline.py

gymnasium.error.Error: Invalid render mode `None`. Supported modes: `human`, `rgb_array`.

to fix: https://github.com/BindsNET/bindsnet/blob/master/bindsnet/environment/environment.py#L92 change it to self.env = gym.make(env_id=name, render_mode=render_mode)

ghost avatar Mar 26 '24 12:03 ghost

Thank you @ioneliabuzatu

Can you make a PR with those changes?

Hananel-Hazan avatar Mar 28 '24 23:03 Hananel-Hazan