Possible to change package name?

[will-stone]

The current package name is "name": "Material-theme". Is it possible to change this? Or will it screw-up users' installation? It may have been originally forked from the Material Theme but the name doesn't really go with the project now.

[Binaryify]

You can see this issues https://github.com/Microsoft/vscode/issues/25988

[will-stone]

Ah ok. If you're unable to change it, you may have to bite-the-bullet and change the name and lose the downloads. I don't think an Atom One Dark theme should have any references to Material, it'll mislead or confuse users.

[Binaryify]

I think it is difficult

[Binaryify]

At fitst, I like the name "Mateial theme", but this issue https://github.com/Binaryify/OneDark-Pro/issues/40 make me to rename this theme

[will-stone]

Indeed. I understand the need for a name change and One Dark Pro is certainly the better choice. However, keeping the package name as Material isn't great. It might be a case of deprecating this and starting a new repo. You could put a big message at the top of the README and a link to the new theme. Could also change logo to small message: "deprecated" too. It's drastic, I know, but will make sense in the long run. That's unless MS can rename it, but I doubt they can.

[Binaryify]

@will-stone Can you help me to contact the VS Code team to solve this thing?

[will-stone]

It looks like this has been assigned a Microsoft representative so we'll have to wait and see what they say. I'm just outlining some options if it's impossible to rename (which it probably is as that ID will be how users' VSCode's know which extension to download). I've never published an extension before, does this page allow you to change anything? https://marketplace.visualstudio.com/manage

[Binaryify]

@will-stone Seem I can't change package name with no lose the downloads https://github.com/Microsoft/vscode/issues/25988 But I publish the new theme with new package name https://marketplace.visualstudio.com/search?term=zhuangtongfa&target=VSCode&category=Themes&sortBy=Relevance

[ajitid]

But this theme doesn't get updates

[Binaryify]

@ajitid Oh, I forget it, now it had been update

[will-stone]

Is the plan to deprecate the old version? I'm not sure what the process would be, just interested.

[Binaryify]

@will-stone I don't know how to do will be better

[jens1o]

@Binaryify I think with the next update, we should place a notice, so that more and more users are installing the new version.

[Binaryify]

@jens1o @will-stone I think we can make it be a "Beautiful mistake"

[jens1o]

So we're just using the old version, even though it's identifier is wrong?

[Binaryify]

@jens1o I think that's acceptable

[jens1o]

So we can close this issue? Maybe you pull down the new version?

[ravindUwU]

I accidentally uninstalled this extension upon noticing that the identifier zhuangtongfa.Material-theme was listed in the output of the code --list-extensions command 🤷‍♂️ .

It is my opinion that, despite the reputation of this extension, it should be published with a new identifier that isn't misleading, as,

• The current identifier is not at all descriptive of the extension.
• Material design is a widely known design language, which isn't relevant to this extension.

[will-stone]

@Binaryify Looks like my prediction of "it'll mislead or confuse users" has come true 😮

[Binaryify]

@will-stone still waiting vscode team improve it https://github.com/Microsoft/vscode/issues/34812#issuecomment-331450423

[will-stone]

Awesome. Looks like it's in the works.

[Binaryify]

@will-stone yes!

[Binaryify]

in the insider version can change the extension name or publisher now but I still don't know how to change it

[sxyugao]

Do you know how to change package name now? It let me bother.

[Huxpro]

in the insider version can change the extension name or publisher now but I still don't know how to change it

Did this feature land?

[ElecTreeFrying]

@Binaryify have you tried updating"name" in package.json to "one-dark-pro"? I also wanted to rename my extension. I resolved into what you did I renamed the "displayName".

[Binaryify]

@ElecTreeFrying that will lose download and install data