fluxxor icon indicating copy to clipboard operation
fluxxor copied to clipboard

Upgrade examples/react-router to use react-router 1.0-rc1

Open andrewslater opened this issue 8 years ago • 3 comments

Upgrades the react-router example to use react-router 1.0-rc1

Was trying to reproduce the issue I'm seeing as documented in https://github.com/BinaryMuse/fluxxor/issues/141 however even after upgrading to react-router 1.0-rc1 I am not able to reproduce the issue where I see

Warning: owner-based and parent-based contexts differ (values: `undefined` vs `[object Object]`) for key (flux) while mounting module.exports (see: http://fb.me/react-context-by-parent)

when injecting fluxxor into my router components in another app I'm working on. Nevertheless this code to migrate to react-router 1.0-rc1 may be useful to the Fluxxor project.

andrewslater avatar Sep 22 '15 19:09 andrewslater

Thanks for this, @andrewslater. I'm going to wait for React Router 1.0 final to hit to update the site and example, but this will be useful for the update.

BinaryMuse avatar Sep 22 '15 20:09 BinaryMuse

I get the same error after migrating to react-router 1.0.0-rc1

nosovsh avatar Oct 03 '15 13:10 nosovsh

See this comment for an explanation of the context issue.

BinaryMuse avatar Oct 10 '15 17:10 BinaryMuse