bap icon indicating copy to clipboard operation
bap copied to clipboard

Published 20 hours ago • verified publisher icon BinaryAnalysisPlatform

Fixes failing PowerPC unit tests

Open bmourad01 opened this issue 10 months ago • 2 comments

The failing tests were all related to load/store instruction encodings. It seems that they accept a sign-extended 16-bit immediate offset in these cases, and the sign extension wasn't being performed by the lifter.

bmourad01 avatar May 04 '24 19:05 bmourad01

cc @gitoleg The git history says you wrote all of this so I wanted to make sure that these changes make sense. I assume at one point the tests were passing.

bmourad01 avatar May 04 '24 19:05 bmourad01

@bmourad01

looks reasonable! But I have no idea why we didn't see this fail before

gitoleg avatar May 06 '24 12:05 gitoleg