Billy O'Neal
Billy O'Neal
Why not instead change: ``` elseif(CMAKE_GENERATOR_PLATFORM MATCHES "^[Ww][Ii][Nn]32$") set(Z_VCPKG_TARGET_TRIPLET_ARCH x86) elseif(CMAKE_GENERATOR_PLATFORM MATCHES "^[Xx]64$") set(Z_VCPKG_TARGET_TRIPLET_ARCH x64) elseif(CMAKE_GENERATOR_PLATFORM MATCHES "^[Aa][Rr][Mm]$") set(Z_VCPKG_TARGET_TRIPLET_ARCH arm) elseif(CMAKE_GENERATOR_PLATFORM MATCHES "^[Aa][Rr][Mm]64$") set(Z_VCPKG_TARGET_TRIPLET_ARCH arm64) ``` to ``` elseif(CMAKE_GENERATOR_PLATFORM MATCHES...
> @BillyONeal That logic is wrong. OK, I'm not sure on the exact interactions between these variables. Only that doing this for arm64 and nothing else seems incorrect.
> @BillyONeal How many **native** architectures are there for VS? Hmmm... fair enough. This is setting target though. Maybe that makes sense. I'm not sure though.
Tagging this with reviewed to make sure I consider it with part 8 and 9 which are both also reviewed right now.
> In my opinion all packages with `X_VCPKG_FORCE_X_LIBRARIES` should be empty libraries, and instead of controlling behavior through a triplet variable it should be done through an overlay. I agree...
I discussed this over chat with @vicroms and he pointed out this is different than the other "X" PRs because it leaves these ports completely untested. They become empty on...
I'm not sure I understand: the problem described above is * This plugin must be built as a DLL/SO/DYLIB * SO/DYLIBs don't work well in vcpkg because POSIX' systems load...
>However this does not work for windows because the install folder is outside the vcpkg tree: %APPDATA%\LV2 or %COMMONPROGRAMFILES%\LV2 Can you point to the code that forces a particular location...
Also please apply this fix (or give us permission to do it for you): ```diff diff --git a/ports/rubberband/vcpkg.json b/ports/rubberband/vcpkg.json index f96bc57b9..eef69995b 100644 --- a/ports/rubberband/vcpkg.json +++ b/ports/rubberband/vcpkg.json @@ -9,7 +9,7 @@...
> libsndfile still links against libmp3 even though the feature is now disabled for static builds. I give up and disable static builds here instead. Wait, are you saying that...