Shengye Wang

Results 13 comments of Shengye Wang

I think they have moved to http://github.com/stackb/rules_proto But there is some issue with their py_proto_library rules and I haven't figured out how to deal with it... My patch is here:...

I was not able to reproduce the problem (using some of my `catkin_grpc_examples` packages). In theory, `#include "Echo.pb.h"` should work. Can you confirm in `package.xml`, `parrot_comm` `build_depend` on `parrot_common_wrapper`? Also,...

Also, some other mistakes in your `CMakeLists.txt` parrot_common_wrapper: ``` catkin_package( LIBRARIES parrot_common_wrapper ${ALL_PROTOBUF_LIBS} CATKIN_DEPENDS grpc ) ``` parrot_comm: ``` target_link_libraries(parrot_comm ${catkin_LIBRARIES}) ```

Strangely, these packages built without any issue on my computer. Can you also report your catkin version? Did you use `catkin build` or `catkin_make`? Are you running catkin is isolated...

Thanks for the information. I was using `catkin-tools`. I will test with `catkin_make` and try to debug. Meanwhile, is there any chance that you can use `catkin-tools` to test if...

I can confirm the bug with `catkin_make`. I will try to dig into it when I have time.

Temporary workaround: Include the following lines in `linked_package/CMakeLists.txt` ``` include_directories(${CATKIN_DEVEL_PREFIX}/${CATKIN_GLOBAL_INCLUDE_DESTINATION}) ```

It seems ROS's message generation adds the include directory in their CMakeList rules. https://github.com/ros/gencpp/blob/b41ee3060badd660662e21cd9d4f81971c87a420/cmake/gencpp-extras.cmake.em#L69 Maybe we should also do that in the `CMakeLists.txt` in `grpc` package. When a user `find`...

Seems to be fixed by #47

https://github.com/grpc/grpc/issues/1165 Upstream is not prioritizing this at this moment. I will leave this issue open, but it won’t be fixed until they release `python-grpc`.