PersistentBottomNavBar icon indicating copy to clipboard operation
PersistentBottomNavBar copied to clipboard

Fixed onWillPop assert error

Open yu1ro opened this issue 2 years ago • 7 comments

fix #308

yu1ro avatar Oct 09 '22 22:10 yu1ro

@BilalShahid13 can you please merge this PR? It's needed for the willPopScope to work properly.

Thank you!

ayoubm avatar Oct 10 '22 18:10 ayoubm

@yu1ro +1

pishguy avatar Nov 09 '22 05:11 pishguy

Hello, can help merge this PR? willPopScope not working properly in PersistentTabView.custom.

htunlin-kitesense avatar Feb 28 '23 04:02 htunlin-kitesense

Hey, would be nice if someone could merge this please. As @htunlin-kitesense mentioned, PersistentTabView.custom is currently impossible to use.

danielcabral-code avatar Mar 03 '23 17:03 danielcabral-code

In flutter 3.7.8, the onWillPop creates some casting problems, which can be fixed by changing it to this:

onWillPop: !widget.handleAndroidBackButtonPress && widget.onWillPop != null ? () async { final result = await widget.onWillPop!(_contextList[_controller!.index]); return Future.value(result); }

AndreSait avatar Apr 26 '23 17:04 AndreSait

Please help to merge this PR :c

pupubird avatar Jul 06 '23 04:07 pupubird

For anyone ever come to this issue, here's the V2 that's actively maintained https://pub.dev/packages/persistent_bottom_nav_bar_v2

pupubird avatar Nov 30 '23 15:11 pupubird