PersistentBottomNavBar icon indicating copy to clipboard operation
PersistentBottomNavBar copied to clipboard

PersistentTabView.custom should also take onItemSelected as parameter

Open jcblancomartinez opened this issue 3 years ago • 4 comments

Hi,

I use PersistentTabView.custom because I have my own logic to build the navigation bar widget.

We are setting handleAndroidBackButtonPress to true and we expect, whenever the user clicks on back, the navigation bar widget refreshes.

Alike PersistentTabView constructor, we want PersistentTabView.custom to also accept "ValueChanged? onItemSelected" as parameter and pass it over to the parent class.

This would allow us to setState within onItemSelected that would get executed when the user clicks on back button.

The change is very simple.

Thanks.

Best Regards.

jcblancomartinez avatar May 14 '21 18:05 jcblancomartinez

@BilalShahid13 does this make sense to you?

Thanks.

jcblancomartinez avatar May 14 '21 18:05 jcblancomartinez

@BilalShahid13 if I send a pull request, will you be able to look at it?

Thanks.

jcblancomartinez avatar May 27 '21 07:05 jcblancomartinez

Facing the same issue, @BilalShahid13 Can it be implemented ?

Coder-Manuel avatar Jul 01 '21 22:07 Coder-Manuel

Hello @Rohithgilla12 i've created a PR that fixes this issue.... You can consider it.. #255 Thanks.

Coder-Manuel avatar Nov 08 '21 08:11 Coder-Manuel