Bilal Bassam

Results 133 comments of Bilal Bassam

> The convention used by [npm](https://docs.npmjs.com/cli/v8/configuring-npm/package-json#git-urls-as-dependencies) is url#sha1 or url#tag. We can use the same here. I will be using something similar here as well then. > On single-file packages,...

@squeek502 Can this be reviewed/merged quickly? It seems to be a major issue around

I've explained well enough why this happen in #303, basically `socket:write()` finishes and executes the callback too quickly on an empty chunk when wrapped with secure-socket, the callback tries to...

> but would it just be easier to reject a body for GET requests @SinisterRectus Oh didn't notice you've specified GET requests with this mitigation. I did mention this in...

This is pretty late sorry for that, but if you are still interested here it is: As you might have knew, coro-http is suppose to be called inside a coroutine...

This also adds `embeds` fields effectively conflicting with PR #339, this should be removed from this PR. I don't have a strong opinion about adding a `components` field here, although...

we may also want to re-publish the binaries in Luvi tag v2.12.0 or perhaps rename it?

For me, I am getting the following when building Luvit on Linux: ```sh Uncaught Error: /mnt/bilal/home/Desktop/luvit/deps/dns.lua:690: attempt to perform arithmetic on local 'len_lo' (a nil value) stack traceback: /mnt/bilal/home/Desktop/luvit/deps/dns.lua:690: in...

I've also confirmed: > Changing the test from using google.com to using nodejs.org fixes it (this is the domain the node test-dns uses) makes it somehow work just fine without...

I have just noticed that it doesn't have to be a different domain, just changing it to `www.google.com` seems to work. That's qutie weird but I guess it is not...