Scarlet-Notes icon indicating copy to clipboard operation
Scarlet-Notes copied to clipboard

Hide/disable bottom toolbar actions in certain contexts

Open Fs00 opened this issue 5 years ago • 1 comments

This PR aims to accomplish what #140 tried to do, with some changes based on the feedback received. Now the button to create a folder is disabled when inside a folder (and not hidden anymore), while in Trash section all buttons are replaced with a single action to delete permanently all notes (which has been moved down from the trash notice toolbar, since IMHO its intent wasn't clear enough in that place).

Here's a screencast showcasing the changes: https://streamable.com/5i3qe

About the argument of the independence of the toolbar from the content of the screen, which was brought up in the previous PR, here's a quote directly from the Material Design guidelines:

To support the intent of different sections of an app, the layout and actions of a bottom app bar can be changed to suit each screen.

I think this a perfect case where bottom bar actions should change, since none of the other three apply to the context of the trash (and therefore are confusing for the user).

Fs00 avatar Mar 21 '20 14:03 Fs00

@BijoySingh Is there any chance that my PRs will get merged? Can we consider Scarlet an abandoned project?

Fs00 avatar Oct 25 '20 11:10 Fs00

Merged in my personal fork.

Fs00 avatar Oct 28 '22 07:10 Fs00