BiglyBT icon indicating copy to clipboard operation
BiglyBT copied to clipboard

Let have a different INSTALL_DIR and PROGRAM_DIR

Open sergiomb2 opened this issue 3 years ago • 2 comments

Regarding issue #2157 , I noticed that -Djava.library.path= and -Dazureus.install.path are always equal but can be different , let install plugins on homedir while main jar is installed java.library.path , fix my packaging problem .

sergiomb2 avatar Jul 14 '21 00:07 sergiomb2

@sergiomb2

My only suggestion (bikeshedders, assemble!) would be to go with something other than INSTALL_DIR, if the example path is going to be pointed at the user's $HOME/.biglybt directory. That's not really any kind of "install" dir. CONFIG_DIR or SETTINGS_DIR or USER_PLUGINS_DIR or something like that strikes me as more descriptive, if that's where it's expected to point.

And if that's not where it's expected to point (like, say, it's pointing instead to a shared plugins path), then I'd still go with PLUGINS_DIR or something like that. PROGRAM_DIR and INSTALL_DIR sound like the exact same thing, to me.

ferdnyc avatar Nov 27 '21 20:11 ferdnyc

@sergiomb2

My only suggestion (bikeshedders, assemble!) would be to go with something other than INSTALL_DIR, if the example path is going to be pointed at the user's $HOME/.biglybt directory. That's not really any kind of "install" dir. CONFIG_DIR or SETTINGS_DIR or USER_PLUGINS_DIR or something like that strikes me as more descriptive, if that's where it's expected to point.

And if that's not where it's expected to point (like, say, it's pointing instead to a shared plugins path), then I'd still go with PLUGINS_DIR or something like that. PROGRAM_DIR and INSTALL_DIR sound like the exact same thing, to me.

indeed, USER_PLUGINS_DIR is more intuitive , with USER_PLUGINS_DIR we may install plugins in our home directory and have biglybt installed on system, /usr/share/java/biglybt .

thanks for the suggestion

sergiomb2 avatar Jan 14 '24 08:01 sergiomb2