BiglyBT-Android icon indicating copy to clipboard operation
BiglyBT-Android copied to clipboard

(fix): broken ref to submodule 'BiglyBT-plugin-mlDHT'

Open javulticat opened this issue 1 year ago • 0 comments
trafficstars

Problem

Hi! I noticed that the pipeline for your Github Action pages-build-deployment has been consistently failing for nearly a month, with 8 consecutive failed runs since Nov 25th. Upon investigation, it appears the failures are all related to a change made in https://github.com/BiglySoftware/BiglyBT-Android/commit/9ffaab710b72d5943600cceb448d1d08fefaebff. Specifically, the problem appears to be caused by the change made to the commit that the BiglyBT-plugin-mlDHT submodule references: the submodule's commit ref was changed from https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/1bf24e39aab16a9a4ffe9a8246c5d174b416ec37 to https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/77ffcf1ac56d62c700e3d4000e50c495587a5f0d.

Reproduction

The reason that change is causing problems is that the new commit the BiglyBT-plugin-mlDHT submodule is now supposed to reference does not currently appear to exist in the BiglyBT-plugin-mlDHT repository. For example, if you click the link to that commit (https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/77ffcf1ac56d62c700e3d4000e50c495587a5f0d), you'll get a 404. You'll also get a 404 by clicking the current link to the BiglyBT-plugin-mlDHT submodule from this repo:

image

Solution

Looking at the current commit history on the android branch of BiglyBT-plugin-mlDHT, the only commit more recent than https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/1bf24e39aab16a9a4ffe9a8246c5d174b416ec37 that currently exists is https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/7df646696050c490ec1e37c8ce69340b60a8ec74. Therefore, it can be deduced that if https://github.com/BiglySoftware/BiglyBT-Android/commit/9ffaab710b72d5943600cceb448d1d08fefaebff intended to update the commit referenced by the BiglyBT-plugin-mlDHT submodule to a more recent commit than https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/1bf24e39aab16a9a4ffe9a8246c5d174b416ec37, then https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/7df646696050c490ec1e37c8ce69340b60a8ec74 is the only commit that would qualify.

Thus, the only change this PR makes is causing https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/7df646696050c490ec1e37c8ce69340b60a8ec74 (as identified above) to be the commit that will now be referenced by the BiglyBT-plugin-mlDHT submodule (replacing its current problematic reference to the non-extant https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/commit/77ffcf1ac56d62c700e3d4000e50c495587a5f0d).

Verification

It's expected that the intended effect of merging this PR will automatically become fully verifiable within minutes after its merge, as the pages-build-deployment pipeline should get triggered by the merge commit created by merging this PR.

Verification criteria:

Ordered chronologically

  • [ ] After merge, it is confirmed that the link to the BiglyBT-plugin-mlDHT submodule on Github no longer leads to a 404 page, but instead leads successfully to this page: https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/tree/7df646696050c490ec1e37c8ce69340b60a8ec74 [Immediately]
  • [ ] After merge, it is confirmed that the pages-build-deployment pipeline associated with this PR's merge commit ran successfully [Within minutes]
  • [ ] After merge, it is confirmed that the latest deployment of github-pages changed from having been deployed a month ago by pipeline #148 to having been deployed recently by the pipeline associated with this PR's merge commit (the same pipeline the above criterion refers to) [Within minutes]

fin

Hope this helps!

javulticat avatar Dec 23 '23 21:12 javulticat