large upload to wago fails

[arkayenro]

it was failing with this error - curl: (92) HTTP/2 stream 0 was not closed cleanly: PROTOCOL_ERROR (err 1)

my addon is large(ish), 1.43mb, and while it will upload to curse and wowi without a problem it will fail with that error to wago.

a small 43k test addon to wago works without any issues so the underlying code is valid and it was something else, probably size related..

googling the error seemed to indicate either a http version issue (2.0 vs 1.1 type thing) or a buffer size limitation.

i tried adding --http1.1 to the curl command in the wago section but it still failed.

when i added the --no-buffer option it worked.

if theres no downside to adding that option could the code be updated to include it in the wago section please?

edit: while it worked for my test addon it did not work for my main addon and thats still failing with the error so maybe its something else

[nebularg]

It's an issue with wago servers that I haven't found a way to mitigate.

[arkayenro]

figured it out (at least i think i have, and its working so far after multiple packages).

the wago secret appears to have a newline at the end (or theres something funky with it). i added a line to echo out what it was checking and the closing bracket (around the secret) would be on the next line for the project that was failing, but would be on the same line for the test project that always worked. it should have been the same secret value for both projects so they should have been the same.

so id see[***] vs [*** ]

i created a new api token in wago and updated the wago secret in both projects and both projects are now uploading to wago without any issues.

im not sure how a "broken" secret would ever work in the first place. i would have expected an auth failure instead.

i doubt its anything to do with the code but if you have a broken project that you can test with to be able to confirm a new secret works? otherwise i guess just close this.

[nebularg]

interesting, the last person to report this also "fixed" it by regenerating their wago token

[janpantel]

@arkayenro this is an interesting find, did you use the copy to clipboard button to copy the secret? I'm wondering how a newline made its way in there. I agree tho, the response is far from perfect.

PS: i'm one of the devs of wago addons

[arkayenro]

i think i did but this would have been my first time with secrets so i most likely pasted it into notepad first to check it and when ive copied it from there ive grabbed the line, not just the secret, and it got pasted with the cr/nl on the end.

it should be fairly simple to test though, and hopefully work out why its not generating an auth failure.