cubism-es icon indicating copy to clipboard operation
cubism-es copied to clipboard

Published 20 hours ago • verified publisher icon BigFatDog

Upgrading to D3V6

Open Fallstop opened this issue 4 years ago • 11 comments

The latest version of cubism-es is incompatible with the latest D3 library version realised last September, namely one of the issues is the API change around d3-selection new event manager (d3.mouse -> d3.pointer).

Is there a plan to upgrade? If wanted, I can submit a pull request with the changes necessary to both the library and demos.

Fallstop avatar Jan 01 '21 20:01 Fallstop

Because of the lack of activity, I'll just go ahead and attempt to do it myself.

Fallstop avatar Jan 04 '21 08:01 Fallstop

Thank you. Once you make a pull request I'll merge it.

BigFatDog avatar Jan 04 '21 13:01 BigFatDog

Any update on this @Fallstop? I'd be happy to test.

aspiers avatar Feb 19 '21 13:02 aspiers

Sorry! Completely forgot about this. It's mostly done as there was not a lot of API changes, but my testing method is very jank. Is there an example repo that I could use to test the changes?

Fallstop avatar Feb 20 '21 18:02 Fallstop

You can presumably use the demos in this repo: https://github.com/BigFatDog/cubism-es/tree/master/demo

aspiers avatar Feb 20 '21 18:02 aspiers

That's what I thought too. But those are all using DISCRETE CUBISM.JS, a modified version of the original cubism, and don't use cubism-es.

Fallstop avatar Feb 20 '21 18:02 Fallstop

That's not correct:

  1. Only demo/discrete-cubism.html is using demo/discrete-cubism.js; none of the others are.
  2. demo/discrete-cubism.js is not a modified version of the original cubism, it's some code specific to the discrete-cubism demo, and that demo, like all the others uses cubism-es:

https://github.com/BigFatDog/cubism-es/blob/c8dd327e549148c29fcfed86c38bbd4748018937/demo/discrete-cubism.html#L20

aspiers avatar Feb 20 '21 19:02 aspiers

Any news ?

throrin19 avatar Jul 01 '22 13:07 throrin19

@Fallstop can you push your work in progress in your repo ?

mpatou avatar Feb 29 '24 22:02 mpatou

I made a few commits in my fork to:

  • update dependencies: https://github.com/ekacnet/cubism-es/tree/update_deps
  • update d3: https://github.com/ekacnet/cubism-es/commits/update_d3
  • add github actions: https://github.com/ekacnet/cubism-es/tree/add_github_actions

I don't know how much @BigFatDog is still active on this project if not active I might end up publishing something on npm on my own.

ekacnet avatar Mar 10 '24 23:03 ekacnet

All my changes are available in my dev branch on: https://github.com/ekacnet/cubism-es/tree/dev.

ekacnet avatar Mar 18 '24 15:03 ekacnet