'Add definition in this file' should not always add 'inline' when declaration is in CPP

[L0PiTaL]

'Add definition in this file' always add the 'inline' keyword.

For header declarations, where the definition will be placed also in the header, this is correct. But if the declaration is in the implementation file, it is not required.

In general, it would be nice to add an option to not adding the inline keyword if the declaration does not contain 'inline', so we can control if it should be generated or not.

By the way, great tool! vscode absolutely needed something like this!

[BigBahss]

I could have sworn that I added logic to account for this scenario in order to omit the inline keyword... there might be a bug here. I will test this when I am able and I might need more info if I'm not able to recreate this.

I'd like to avoid adding new settings if possible, just so that the available options don't get bloated. But if necessary I will add one.

Thank you for submitting this and I'm glad you like the tool!

[L0PiTaL]

Perfect, thank you! If you need something else, just tell me.

I agree with you, options are usually a bit overwhelming. I think it would be enough to add inline or not depending on if it already exists in the declaration, but I don't know the internals, so do as you consider.

Thank you very much!