androidsvg icon indicating copy to clipboard operation
androidsvg copied to clipboard

Click events for SVG Elements

Open i-mitra opened this issue 4 years ago • 3 comments

Hey Paul,

Before I go ahead and added more flexibilities and features for click events, I thought I'd review with you some of the changes on SVG and SVGBase.

  • SVGBase I added couple of methods for us to fetch all elements at a specific location, which can be restricted to only elements with ids. We could move containsCoords into Box as it's more of a helper method for Box.
  • SVG Just exposing getElementsAt from base.
  • SVGRenderer Rather than fetching for ids, I thought we might as well put them in idToElementMap while creating the render tree. We could change this to getIdToElementMap().put(id, obj). Moreover we can then expose getIdToElementMap().

Let me know what you think.

Ishan

i-mitra avatar Jul 19 '21 11:07 i-mitra

Thanks. This looks useful. I'll look through the code as soon as I have a bit of time, and add some comments.

BigBadaboom avatar Jul 20 '21 10:07 BigBadaboom

any update on this Merge Request ?

debugnrebuild avatar Oct 05 '22 17:10 debugnrebuild