napari-clusters-plotter icon indicating copy to clipboard operation
napari-clusters-plotter copied to clipboard

unpin numpy version

Open Cryaaa opened this issue 1 year ago • 1 comments

Changed the dependencies to not rely on pinned numpy versions which are no longer supported by libraries like zarr. Thanks to @ziw-liu for bringing it up. Once merged this will close issue #215. I know this will be fixed anyway in v 0.9.0 but it might be good to fix it in this release in case the new version has some backwards compatibility breaking changes.

Cryaaa avatar Sep 17 '24 10:09 Cryaaa

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.47%. Comparing base (c7bae7b) to head (43f5f82). Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files          16       16           
  Lines        2076     2076           
=======================================
  Hits         1650     1650           
  Misses        426      426           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 17 '24 10:09 codecov[bot]

Thanks for the fix! It would be great if this can get merged and release soon.

ziw-liu avatar Oct 16 '24 23:10 ziw-liu

Hi guys!

Just two questions to this. Could this enable numpy > 2.0 to be installed along with the plugin? If so, have you tested the plugin with it?

I am asking because numpy >2.0 brings many changes and some things may not work anymore, and the changes above wouldn't restrain it unless some other dependency does.

zoccoler avatar Oct 21 '24 09:10 zoccoler

fwiw the CI tests for https://github.com/BiAPoL/napari-clusters-plotter/pull/345/commits/43f5f8297f41927eb5993b95092aaf9f90bb1583 was done with numpy>2:

numpy-2.0.2                |   py39h9cb892a_0         7.4 MB  conda-forge

Edit: I also tested the plotting widget manually with numpy==2.0.2.

ziw-liu avatar Oct 21 '24 16:10 ziw-liu

I also just tested all the plotting, dimensionality reduction and clustering functions from the GUI and couldn't spot anything when numpy 2.0 is used. I tested with surface, point, 3D tracking and 2D time-lapse data. If you don't have any other concerns @zoccoler I will just merge this and then we can release the new version?

Cryaaa avatar Oct 22 '24 14:10 Cryaaa

Awesome! Then please feel free to merge @Cryaaa !

zoccoler avatar Oct 24 '24 19:10 zoccoler