30-seconds-of-cpp icon indicating copy to clipboard operation
30-seconds-of-cpp copied to clipboard

Add new methods in different header directories

Open Bhupesh-V opened this issue 6 years ago • 24 comments

This is for first-time-contributors : Add functions which belong to a particular header file in its corresponding .md file inside the header folder. For example std::sort belongs to algorithm header file, so make a new file sort.md inside the algorithm directory while maintaining the CONTIBUTING guidelines and formats.

See todo.txt file in different header directory to see which of the methods have not been implemented yet.

Bhupesh-V avatar Feb 16 '19 06:02 Bhupesh-V

are you saying you want the sort in sort.md moved to algorithm.md?

willdarnell avatar May 15 '19 14:05 willdarnell

Is this issue solved? If not, I could try to do it.

dantedallag avatar Jul 11 '19 02:07 dantedallag

@dantedallag this issue always remains open to help contributors .

Bhupesh-V avatar Jul 11 '19 14:07 Bhupesh-V

Can I contribute to this issue?

HarshitNITT avatar Sep 14 '19 15:09 HarshitNITT

Can I contribute to this issue?

Yes you can, just see the unimplemented functions in the README.md files inside different directories

Bhupesh-V avatar Sep 15 '19 06:09 Bhupesh-V

Hi, I am new to open source in general, and I would like to contribute as a beginner. I have a few doubts:

  1. How can I differentiate which functions are unimplemented in the README.md file?
  2. I also want to make sure if the process of contributing that I understand is right or not: At the time of writing this, the pop_back() function is not yet implemented yet. So is this what I do - I write a sample code that implements this function (by following the coding conventions of course), and this code will reside in snippet/vector. And I also make a .md file in vector directory (outside snippet) which explains the code. Is there anything that I am missing? If yes, please tell me so that I begin.

ghost avatar Sep 26 '19 11:09 ghost

@saisriram2710 you are right

Bhupesh-V avatar Oct 04 '19 06:10 Bhupesh-V

Can i contribute to this issue ?

agrawalsajal02 avatar Oct 09 '19 13:10 agrawalsajal02

submitted a pull request 257

agrawalsajal02 avatar Oct 09 '19 14:10 agrawalsajal02

Hi, I want to contribute to this issue. Where do i start?

sakibmahmud avatar Oct 11 '19 01:10 sakibmahmud

can i contribute to this issue??

satcasm avatar Oct 21 '19 02:10 satcasm

Hello! I would like to contribute to this issue. I have reviewed the CONTRIBUTING.md, looked at the Projects, and referenced the Kanban for each directory type. I would like to work on "pop_back" under Vector. If successful, this will be my very first Open Source contribution :) Thank you @Bhupesh-V for making this opportunity available. So far, the instructions have been very complete and helpful.

marcinky avatar May 31 '20 14:05 marcinky

Hello! I would like to contribute to this issue. I have reviewed the CONTRIBUTING.md, looked at the Projects, and referenced the Kanban for each directory type. I would like to work on "pop_back" under Vector. If successful, this will be my very first Open Source contribution :) Thank you @Bhupesh-V for making this opportunity available. So far, the instructions have been very complete and helpful.

@marcinky looks like pop_back is already implemented and only crend is available to contribute. Don't worry just head over to specific directories like list where pop_back has not been implemented yet (see :heavy_check_mark: and :x: marks) Go ahead and implement it and welcome to opensource :hugs:

Bhupesh-V avatar May 31 '20 15:05 Bhupesh-V

Ok will do @Bhupesh-V - thank you! I'll take another look.

marcinky avatar May 31 '20 16:05 marcinky

Should I create a new issue before starting to work on code or should I just go ahead and open a pull request?

dbejanishvili avatar Jun 13 '20 12:06 dbejanishvili

Hi Bhupesh Varshney, I would like to contribute to this issue.

I've locally created .md file with an example code for the new 'contains' in the unordered_map for C++20. I've followed your coding guideline and also tested my code. I can create a pull request for review.

Could you please allow me write access to create a PR? Thank you for your help in advance.

athulsasi avatar Sep 23 '20 17:09 athulsasi

Hi Bhupesh Varshney, I just made my first PR for unordered_map 's at function . Please check it out . :)

https://github.com/Bhupesh-V/30-seconds-of-cpp/pull/579

akankshasonkar17 avatar Oct 05 '20 17:10 akankshasonkar17

Hi Bhupesh Varshney, I would like to contribute to this issue.

I've locally created .md file with an example code for the new 'contains' in the unordered_map for C++20. I've followed your coding guideline and also tested my code. I can create a pull request for review.

Could you please allow me write access to create a PR? Thank you for your help in advance.

Hi @athulsasi you don't need any write access to the repo. Everything is listed in CONTRIBUTING guidelines on how & what to contribute.

Bhupesh-V avatar Oct 06 '20 06:10 Bhupesh-V

Hello @Bhupesh-V. I am completely new to open source and would like to contribute to this project, specifically the crend function in the set directory. I really appreciate the opportunity provided for newcomers like me.

Aokison avatar Jun 05 '21 20:06 Aokison

Hi @Bhupesh-V. Can I still contribute to this issue?

adarshcode avatar Oct 05 '21 14:10 adarshcode

@Bhupesh-V I have created a PR please review and suggest changes. #649

varunbgit avatar Dec 15 '21 12:12 varunbgit

@Bhupesh-V I would like to work on this one .

deepanshu2810 avatar Oct 01 '22 10:10 deepanshu2810

Hi @Bhupesh-V Can I contribute to this issue a function to unordered_map?

Anshul-9923 avatar Oct 08 '22 14:10 Anshul-9923

@Bhupesh-V,Hey! I would like to contribute to this, please assign this to me.

Aanya9693 avatar Oct 09 '22 12:10 Aanya9693