Bhargav Ravuri
Bhargav Ravuri
PR #14868 for reading go build flags from env `GO_BUILD_FLAGS`. `-trimpath` already exists in building [etcd][1], [etcdutl][2] & [etcdctl][3]. [1]: https://github.com/etcd-io/etcd/blob/main/scripts/build_lib.sh#L23 [2]: https://github.com/etcd-io/etcd/blob/main/scripts/build_lib.sh#L34 [3]: https://github.com/etcd-io/etcd/blob/main/scripts/build_lib.sh#L45
@Sairaviteja27 Are you still working on this? Or shall I take it up?
@Sairaviteja27 Thanks for confirming! @gjenkins8 Although I'd incline towards having a flag to achieve this behavior from inside helm, I must say, that's a good workaround 👍🏼 `jq` is very...
@undera Thanks for the pointers. It is working as expected. A query before submitting this PR: How does the user enable development versions: 1. Directly from UI, the API response...
@undera Thanks! That makes sense. Please confirm the following: 1. In [Charts()][1], the current logic is only considering a single version (0'th index) of each chart. Any particular reason in...
@undera While I was trying to add tests for these changes, I noticed that they need interfaces for mocking. Otherwise, not testable. However, when I started adding interfaces and tests,...
@undera My apologies, I didn't find time to update you on the progress. I've submitted the commit with test cases. Please review.
Thanks, @undera. I appreciate the help throughout the time. :blush:
/reopen
+1 @zalsader, just adding my thoughts. I haven't come across this issue, but I think `createdAt` should only be updated when "there is an update". I didn't get the background...