Yunze Xu comments

Results 348 comments of


                                            Yunze Xu

[improve][cpp] Support acknowledging a list of messages

Could you rebase to master? I saw some strange errors in CI.

[fix][cpp] Use weak ptr avoid circular references.

Please rebase to master to have some CI fixes.

[BUG]Benchmark driver-kop kafka_to_kafka.yaml kafkaConfig: acks=all(-1) benchmark-worker producer and consumer clients report errors

I see the same issue in https://forum.streamnative.io/t/openmessaging-benchmark-kop/484. Could you follow my suggestion to provide debug logs?

[feat] Napi support package c++ static binary.

> Just for the unified There is no need to make two separate repositories consistent. What if the Python client repo renamed the directory or adjust the hierarchy later? **In...

[fix][client] Fix ConfigurationDataUtils loadConf strategy

Could you continue this work?

[Doc] C++ Client API docs are incompleted

I realized this issue as well. The release process doesn't include the release of C++ docs.

[Doc] C++ Client API docs are incompleted

@tisonkun https://github.com/apache/pulsar-client-cpp/pull/103 will fix the doxygen generation.

[improve] Trigger pending fetches when producing messages

@eolivelli @Demogorgon314 Sorry for the delayed review on this PR. I will review it ASAP.

[improve] Trigger pending fetches when producing messages

Overall LGTM. Merge this PR first.

[improve] Trigger pending fetches when producing messages

Could this PR be cherry-picked into release branches?