bldc-controller icon indicating copy to clipboard operation
bldc-controller copied to clipboard

[Bdt] Switch to dcargs

Open gbalke opened this issue 3 years ago • 3 comments

Signed-off-by: Greg Balke [email protected]

Topic: bdt_uses_dcargs Reviewers: brent

gbalke avatar Sep 26 '22 04:09 gbalke

Reviews in this chain: └https://github.com/BetzDrive/bldc-controller/pull/69 [Bdt] Switch to dcargs

gbalke avatar Sep 26 '22 04:09 gbalke

# head base diff date summary
0 83f41825 f552a7fd diff Sep 25 9:13 PM 4 files changed, 94 insertions(+), 61 deletions(-)
1 0b7072fc f552a7fd diff Oct 04 12:44 AM 1 file changed, 5 insertions(+), 4 deletions(-)

gbalke avatar Sep 26 '22 04:09 gbalke

Discussed offline... I think the current behavior where betz drive tools creates a connection per tool execution is a pretty poor design for doing continuous testing. I believe dcargs will work much better if it doesn't have to deal with lists of lists of command args (which is the current hacky think I'm doing for control_motor. I'll leave this PR and hold off until I have a better architecture in place for the server system.

gbalke avatar Oct 04 '22 07:10 gbalke