alchemist icon indicating copy to clipboard operation
alchemist copied to clipboard
verified publisher icon Betterment

feat: Add an alias for same-package fonts

Open nikodembernat opened this issue 8 months ago • 3 comments

Description

Added an alias for same-package fonts to support running golden tests in packages (e.g. design systems).

Fixes #142

The specified package:yaml lower version constraint is equal to package:yaml pinned in Flutter 3.16 (min. supported version) to avoid version conflicts.

Type of Change

  • [x] ✨ New feature (non-breaking change which adds functionality)
  • [x] 🛠️ Bug fix (non-breaking change which fixes an issue)
  • [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] 🧹 Code refactor
  • [ ] ✅ Build configuration change
  • [ ] 📝 Documentation
  • [ ] 🗑️ Chore

nikodembernat avatar Apr 08 '25 23:04 nikodembernat

Not a big fan of reading package name from pubspec.yaml, if you have a better solution then I'm open to suggestions

nikodembernat avatar Apr 11 '25 14:04 nikodembernat

@btrautmann Haven't touched our package or used it as intensely as you guys probably have. Can you verify the validity of the business logic here?

Code itself LGTM.

jeroen-meijer avatar Apr 15 '25 10:04 jeroen-meijer

From what I see the new goldens are failing since they don't exist, someone with necessary permissions has to regenerate them if I understand the workflow correctly

nikodembernat avatar Apr 28 '25 10:04 nikodembernat