alchemist icon indicating copy to clipboard operation
alchemist copied to clipboard

feat: Add custom textstyle for the name property in a golden test scenario,…

Open NRijnberg opened this issue 1 year ago • 4 comments

Description

Add custom textstyle for the name property in a golden test scenario, this is very useful when your default bodyMedium has a white text color, and the background of the golden test is white as well, this way you can make it visible by providing your own text style

Type of Change

  • [x] ✨ New feature (non-breaking change which adds functionality)
  • [ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
  • [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] 🧹 Code refactor
  • [ ] ✅ Build configuration change
  • [x] 📝 Documentation
  • [ ] 🗑️ Chore

NRijnberg avatar Sep 06 '24 13:09 NRijnberg

@btrautmann @Kirpal I'll leave merging and release up to you. I don't see any issues with this change. 👌🏻

jeroen-meijer avatar Sep 06 '24 13:09 jeroen-meijer

@NRijnberg I'm working on getting this unblocked with an upgrade to 3.16.0.

btrautmann avatar Sep 10 '24 15:09 btrautmann

@NRijnberg I just merged a PR that bumps the min version for Flutter/dart to a version compatible with your PR, so you should be able to rebase and push. Once that's done/in, I'll be able to merge and cut a new version.

btrautmann avatar Sep 11 '24 17:09 btrautmann

I ended up cutting 0.8.0 rather than waiting for this, but feel free to get this back into a good state and we can cut a new version.

btrautmann avatar Sep 12 '24 21:09 btrautmann

Closing in favor of https://github.com/Betterment/alchemist/pull/132.

btrautmann avatar Nov 14 '24 20:11 btrautmann