thunderbird-patches icon indicating copy to clipboard operation
thunderbird-patches copied to clipboard

The bottom part of the 'About Betterbird' Window is cut off

Open kiki-ja opened this issue 1 year ago • 4 comments

The bottom of the 'About Betterbird' window is cut off and the text is not visible. Please see the screenshot. Is this a problem in my environment?

About Betterbird 102-115


I modified it by adding the following two lines to 'aboutDialog.css'.

#leftBox {
  background-image: url("chrome://branding/content/about-logo.svg");
  background-repeat: no-repeat;
  /* min-width and min-height create room for the logo */
  min-width: 210px;
  min-height: 210px;
 + margin-top: 20px; /* add */
 + margin-bottom: 20px; /* add */
  margin-inline-start: 30px;
}

Below is a screenshot of the results.

About Betterbird +20px

Betterbird について +20px

@kiki-ja

kiki-ja avatar Jun 21 '24 03:06 kiki-ja

Hmm, works for me:

Windows: image

Linux: image

Why doesn't it fit for you? Looks like the logo is too small. I can add the margin, it was requested here: Issue #241

Betterbird avatar Jun 21 '24 07:06 Betterbird

Does it work with 10px margin instead of 20px? How about increasing min-height?

Betterbird avatar Jun 21 '24 08:06 Betterbird

I saw your screenshot and it turns out that it seems to be a problem with my system font.

Why doesn't it fit for you? Looks like the logo is too small.

On my Windows 10 PC I have changed the system font and size so the font is probably a bit large for the logo. This is probably why the logo appears small in terms of balance. This may be the reason why the bottom row of text is two lines long and cut off from the window.

My system font: 'BIZ UDGothic font family' https://learn.microsoft.com/en-us/typography/font-list/biz-udgothic

I can add the margin, it was requested here: Issue #241

Seems like a problem with my font. But it is strange because in Thunderbird it is not a problem.(?????) If it is not a problem in other users' environments, then there is no need to add margins.

Does it work with 10px margin instead of 20px?

10px margin would work, but a 20px margin was best.

margin 10px case: About Betterbird +10px Betterbird について +10px

How about increasing min-height?

I tried it, but up the min-height did not make the desired change.


So I will deal with this by customizing it with CSS.

userChrome.css:

#leftBox {
  margin-top: 20px !important;
  margin-bottom: 20px !important;
}

Thank you very much.

@kiki-ja

kiki-ja avatar Jun 21 '24 11:06 kiki-ja

Thanks for the details, we'll consider adding 15px margin since something similar was requested in Issue #241.

Betterbird avatar Jun 21 '24 18:06 Betterbird

How does this issue look in BB 128? We've never addressed it :cry:

Betterbird avatar Dec 06 '24 18:12 Betterbird

Betterbird 128.5.0esr en-US version has no problem. But in Betterbird 128.5.0esr ja version it looks like this. I have added top and bottom margins to the "#leftBox".

bb128 5 0-AboutWindow

[userChrome.css] #leftBox { margin-top: 15px !important; margin-bottom: 20px !important; /* or 15px */ }

If you want the bottom line to be one line, add the following.

~~[userChrome.css] #rightBox { min-width: 230px !important; /* 230px should be changed according to your environment */ }~~

#rightBox does not seem to work, so substitute "#aboutDialogContainer" as shown below. [userChrome.css]

#aboutDialogContainer {
width: 680px !important; /* 680px should be changed according to your environment */
} 

128 - aboutDialogContainer680px-ja

@kiki-ja

kiki-ja avatar Dec 07 '24 15:12 kiki-ja

OK, we'll add the 15px top and bottom margin to finally close the issue. Thanks for your advice.

Betterbird avatar Dec 07 '24 15:12 Betterbird

OK, I added 15px margin to the leftBox. The rightBox had 20px margin, we needed to increase that so text and image line up vertically centred. Of course that brings the text further down and may defy the purpose altogether.

Betterbird avatar Dec 07 '24 18:12 Betterbird

Is this better in 128.5.2 now?

Betterbird avatar Dec 16 '24 19:12 Betterbird

128.5.2 bb19 64bit Windows 10 Pro 22H2 64bit

About Betterbird (ja version) window is good. See screenshot.

128 5 2 about betterbird ja


[Ref] I have made the following customization to make the bottom line of text a single line.

[userChrome.css]

#aboutDialogContainer {
  width: 680px !important;
}

128 5 2 about betterbird ja my custom

@kiki-ja

kiki-ja avatar Dec 17 '24 11:12 kiki-ja

OK, thanks for testing. I actually looked at it with a Japanese language pack and the font was way smaller.

Betterbird avatar Dec 17 '24 12:12 Betterbird

I actually looked at it with a Japanese language pack and the font was way smaller.

That seems to be normal.

In my case, as I mentioned earlier, I have changed the OS system font. Also, its font size is increased by 1 - 2pt. So I have customized it a little.

I would be happy if you could use this as reference information for the Japanese version.

@kiki-ja

kiki-ja avatar Dec 19 '24 11:12 kiki-ja

I would be happy if you could use this as reference information for the Japanese version.

I'm not sure what you want me to do. Everything should be fine now for the Japanese version.

Betterbird avatar Dec 19 '24 15:12 Betterbird