react-zoom-pan-pinch icon indicating copy to clipboard operation
react-zoom-pan-pinch copied to clipboard

Would it be okay to create a fork?

Open janaagaard75 opened this issue 3 years ago • 3 comments

Hi @prc5. It seems that this repository hasn't received much attention lately, and I think that's a big shame because it's really great. We are planning on using it in our upcoming product at my work place.

Would it be okay if I create a fork and release as @company/react-zoom-pan-pinch? First and foremost the fork would fix the issue with the missing source files (#266), update dependencies to fix some of the security issues reported by Dependabot, and finally to ensure it works with React 18 and update the peer dependency (#292).

janaagaard75 avatar Jun 02 '22 20:06 janaagaard75

I have released @pronestor/react-zoom-pan-pinch fork. So far it's just fixing #266.

janaagaard75 avatar Jun 08 '22 11:06 janaagaard75

I will leave this issue open for while, so that @prc5 has a chance to see it.

janaagaard75 avatar Jun 08 '22 11:06 janaagaard75

Thank you @janaagaard75. I'm still learning React and I really did not want to work this bug out :)

I think what you propose should be good because it's under the MIT license

dtemir avatar Jun 13 '22 20:06 dtemir

Thank you so much for doing this @janaagaard75! A real shame that this library has not been given much attention.

kasmoto avatar Jan 01 '23 12:01 kasmoto

You're all welcome. I will pass it along to my boss for allowing me to use some of my time on open source.

There are two things that you can do to help:

  1. See if there are any of the open pull requests to this repo that should be carried over to the fork. I believe that I have made a comment in here, in the ones that have been ported.
  2. There are some bugs that have been reported, that I have yet had time to dig into. If you spend some time on a bug, and only find a partial solution, feel free to comment on the bugs, because your findings might make it easier to create a pull request with a fix.

janaagaard75 avatar Jan 02 '23 09:01 janaagaard75

@janaagaard75 I'm back with maintenence, thanks for helping! If you're interested in working on this, or merging your changes, we can talk about it 🙌🏻

prc5 avatar Jan 15 '23 16:01 prc5

So great to hear that you're back, @prc5. I hope you're well. I would gladly help here, but I all honesty, the only real thing that I managed to change in the fork that I created, was to improve the parameters used in the Storybook stories a bit. It shouldn't be that hard to port these changes to this repo - I'll create a pull request.

janaagaard75 avatar Jan 17 '23 18:01 janaagaard75